| Message ID | 1619774552-118157-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mgag200: Remove redundant assignment to status and clock | expand |
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index cece3e5..c4d5be8 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -95,7 +95,6 @@ static inline void mga_wait_vsync(struct mga_device *mdev) status = RREG32(MGAREG_Status); } while ((status & 0x08) && time_before(jiffies, timeout)); timeout = jiffies + HZ/10; - status = 0; do { status = RREG32(MGAREG_Status); } while (!(status & 0x08) && time_before(jiffies, timeout)); @@ -280,8 +279,6 @@ static int mga_g200se_set_plls(struct mga_device *mdev, long clock) p |= (fvv << 4); m |= 0x80; - - clock = clock / 2; } if (delta > permitteddelta) {
Variable status is set to zero but this value is never read as it is overwritten with a new value later on,clock is being assigned a value from a calculation however the variable is never read,hence these are redundant assignments that can be removed. Clean up the following clang-analyzer warning: drivers/gpu/drm/mgag200/mgag200_mode.c:284:3: warning: Value stored to 'clock' is never read [clang-analyzer-deadcode.DeadStores]. drivers/gpu/drm/mgag200/mgag200_mode.c:98:2: warning: Value stored to 'status' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/gpu/drm/mgag200/mgag200_mode.c | 3 --- 1 file changed, 3 deletions(-)