| Message ID | 1634280490-4429-1-git-send-email-wangqing@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: panel: replace snprintf in show functions with sysfs_emit | expand |
Hi, On Thu, Oct 14, 2021 at 11:48:10PM -0700, Qing Wang wrote: > show() must not use snprintf() when formatting the value to be > returned to user space. > > Fix the following coccicheck warning: > drivers/gpu/drm/panel/panel-dsi-cm.c:251: WARNING: use scnprintf or sprintf. > drivers/gpu/drm/panel/panel-dsi-cm.c:271: WARNING: use scnprintf or sprintf. > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > Signed-off-by: Qing Wang <wangqing@vivo.com> > --- The patch subject could be more specific (this updates just one panel driver). Otherwise: Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > drivers/gpu/drm/panel/panel-dsi-cm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel/panel-dsi-cm.c > index 5fbfb71..a8efb06 100644 > --- a/drivers/gpu/drm/panel/panel-dsi-cm.c > +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c > @@ -248,7 +248,7 @@ static ssize_t num_dsi_errors_show(struct device *dev, > if (r) > return r; > > - return snprintf(buf, PAGE_SIZE, "%d\n", errors); > + return sysfs_emit(buf, "%d\n", errors); > } > > static ssize_t hw_revision_show(struct device *dev, > @@ -268,7 +268,7 @@ static ssize_t hw_revision_show(struct device *dev, > if (r) > return r; > > - return snprintf(buf, PAGE_SIZE, "%02x.%02x.%02x\n", id1, id2, id3); > + return sysfs_emit(buf, "%02x.%02x.%02x\n", id1, id2, id3); > } > > static DEVICE_ATTR_RO(num_dsi_errors); > -- > 2.7.4 >
Hi Qing and Sebastian. On Fri, Oct 15, 2021 at 01:11:39PM +0200, Sebastian Reichel wrote: > Hi, > > On Thu, Oct 14, 2021 at 11:48:10PM -0700, Qing Wang wrote: > > show() must not use snprintf() when formatting the value to be > > returned to user space. > > > > Fix the following coccicheck warning: > > drivers/gpu/drm/panel/panel-dsi-cm.c:251: WARNING: use scnprintf or sprintf. > > drivers/gpu/drm/panel/panel-dsi-cm.c:271: WARNING: use scnprintf or sprintf. > > > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > > > Signed-off-by: Qing Wang <wangqing@vivo.com> > > --- > > The patch subject could be more specific (this updates just one panel driver). > Otherwise: > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Updated the patch subject and applied the patch to drm-misc-next. It will show up in -next in 1-2 weeks. Sam
diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel/panel-dsi-cm.c index 5fbfb71..a8efb06 100644 --- a/drivers/gpu/drm/panel/panel-dsi-cm.c +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c @@ -248,7 +248,7 @@ static ssize_t num_dsi_errors_show(struct device *dev, if (r) return r; - return snprintf(buf, PAGE_SIZE, "%d\n", errors); + return sysfs_emit(buf, "%d\n", errors); } static ssize_t hw_revision_show(struct device *dev, @@ -268,7 +268,7 @@ static ssize_t hw_revision_show(struct device *dev, if (r) return r; - return snprintf(buf, PAGE_SIZE, "%02x.%02x.%02x\n", id1, id2, id3); + return sysfs_emit(buf, "%02x.%02x.%02x\n", id1, id2, id3); } static DEVICE_ATTR_RO(num_dsi_errors);
show() must not use snprintf() when formatting the value to be returned to user space. Fix the following coccicheck warning: drivers/gpu/drm/panel/panel-dsi-cm.c:251: WARNING: use scnprintf or sprintf. drivers/gpu/drm/panel/panel-dsi-cm.c:271: WARNING: use scnprintf or sprintf. Use sysfs_emit instead of scnprintf or sprintf makes more sense. Signed-off-by: Qing Wang <wangqing@vivo.com> --- drivers/gpu/drm/panel/panel-dsi-cm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)