From patchwork Tue Mar 25 11:06:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 3887251 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2530D9F2E8 for ; Tue, 25 Mar 2014 11:07:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3E1D12020E for ; Tue, 25 Mar 2014 11:07:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 0352E201F5 for ; Tue, 25 Mar 2014 11:07:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B41F89A35; Tue, 25 Mar 2014 04:07:01 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) by gabe.freedesktop.org (Postfix) with ESMTP id 81E4889A35 for ; Tue, 25 Mar 2014 04:06:59 -0700 (PDT) Received: from wuerfel.localnet (HSI-KBW-134-3-135-108.hsi14.kabel-badenwuerttemberg.de [134.3.135.108]) by mrelayeu.kundenserver.de (node=mreue006) with ESMTP (Nemesis) id 0M2TKr-1XK6Co2QxZ-00sKPL; Tue, 25 Mar 2014 12:06:48 +0100 From: Arnd Bergmann To: Dave Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] drm/bridge: PTN3460 needs DRM_KMS_HELPER Date: Tue, 25 Mar 2014 12:06:46 +0100 Message-ID: <17602160.PV0AMDU1du@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V02:K0:00YiMeh2fczj+sxrhXN1IIJ728Z0fug/GMu0bnPyJ6X q5RhAzLpVES83OuBA4HF0/psbR9N1H+V53N81vR+Ngcr2xNDsc i479o/Kl95IWOmoupwuOJQOE/M5tVZRkhNs8ltxmZuQGCZAKTh XYgYUqf4XycgtVPvR6IkSyv/F6FuzH4G8uAyUKs4zd9qfD8TBQ XiD3AIJN97cXVblHS4iewD23twn2b/xswMXAOaO/uI0ZRn6vbP 7Kay+w3w4FG9Thdm5KJZD5rBnCr9gTe/TND2gxvSLgV7peN8A+ VZrsezmx+hITT6wmLmU9kS64Fo0nHCRQpCoAbrwvZTtlSqNVRq WErKx5upj98Qrws7+HqM= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The recently added PTN3460 device driver uses interfaces that are provided by the KMS helper infrastructure, so we should explicitly select that to avoid this linker error: ERROR: "drm_helper_probe_single_connector_modes" [drivers/gpu/drm/bridge/ptn3460.ko] undefined! ERROR: "drm_helper_connector_dpms" [drivers/gpu/drm/bridge/ptn3460.ko] undefined! We have to drop the I2C dependency to avoid a circular dependency chain, but that's ok because DRM already selects I2C. Signed-off-by: Arnd Bergmann --- I found this today doing randconfig builds on linux-next. diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index f8db069..884923f 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -1,4 +1,5 @@ config DRM_PTN3460 tristate "PTN3460 DP/LVDS bridge" - depends on DRM && I2C + depends on DRM + select DRM_KMS_HELPER ---help---