| Message ID | 1912536b0972568efc3d4f96c89de96b2abd7510.1680273039.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: shmobile: Fixes and enhancements | expand |
Hi Geert, Thank you for the patch. On Fri, Mar 31, 2023 at 04:48:07PM +0200, Geert Uytterhoeven wrote: > Replace the printing of hexadecimal fourcc format codes by > pretty-printed format names, using the "%p4cc" format specifier. I really like %p4cc :-) I makes things much neater. > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4 ++-- > drivers/gpu/drm/shmobile/shmob_drm_kms.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > index d354ab3077cecf94..713a7612244c647a 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > @@ -355,8 +355,8 @@ static int shmob_drm_crtc_mode_set(struct drm_crtc *crtc, > > format = shmob_drm_format_info(crtc->primary->fb->format->format); > if (format == NULL) { > - dev_dbg(sdev->dev, "mode_set: unsupported format %08x\n", > - crtc->primary->fb->format->format); > + dev_dbg(sdev->dev, "mode_set: unsupported format %p4cc\n", > + &crtc->primary->fb->format->format); > return -EINVAL; > } > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_kms.c b/drivers/gpu/drm/shmobile/shmob_drm_kms.c > index 60a2c8d8a0d947d2..3c5fe3bc183c7c13 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_kms.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_kms.c > @@ -96,8 +96,8 @@ shmob_drm_fb_create(struct drm_device *dev, struct drm_file *file_priv, > > format = shmob_drm_format_info(mode_cmd->pixel_format); > if (format == NULL) { > - dev_dbg(dev->dev, "unsupported pixel format %08x\n", > - mode_cmd->pixel_format); > + dev_dbg(dev->dev, "unsupported pixel format %p4cc\n", > + &mode_cmd->pixel_format); > return ERR_PTR(-EINVAL); > } >
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c index d354ab3077cecf94..713a7612244c647a 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c @@ -355,8 +355,8 @@ static int shmob_drm_crtc_mode_set(struct drm_crtc *crtc, format = shmob_drm_format_info(crtc->primary->fb->format->format); if (format == NULL) { - dev_dbg(sdev->dev, "mode_set: unsupported format %08x\n", - crtc->primary->fb->format->format); + dev_dbg(sdev->dev, "mode_set: unsupported format %p4cc\n", + &crtc->primary->fb->format->format); return -EINVAL; } diff --git a/drivers/gpu/drm/shmobile/shmob_drm_kms.c b/drivers/gpu/drm/shmobile/shmob_drm_kms.c index 60a2c8d8a0d947d2..3c5fe3bc183c7c13 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_kms.c +++ b/drivers/gpu/drm/shmobile/shmob_drm_kms.c @@ -96,8 +96,8 @@ shmob_drm_fb_create(struct drm_device *dev, struct drm_file *file_priv, format = shmob_drm_format_info(mode_cmd->pixel_format); if (format == NULL) { - dev_dbg(dev->dev, "unsupported pixel format %08x\n", - mode_cmd->pixel_format); + dev_dbg(dev->dev, "unsupported pixel format %p4cc\n", + &mode_cmd->pixel_format); return ERR_PTR(-EINVAL); }
Replace the printing of hexadecimal fourcc format codes by pretty-printed format names, using the "%p4cc" format specifier. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4 ++-- drivers/gpu/drm/shmobile/shmob_drm_kms.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)