From patchwork Wed Feb 18 16:09:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 5847501 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 89E949F269 for ; Wed, 18 Feb 2015 19:48:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A58A120219 for ; Wed, 18 Feb 2015 19:48:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id D4215201FE for ; Wed, 18 Feb 2015 19:48:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C56EA6E553; Wed, 18 Feb 2015 11:48:42 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by gabe.freedesktop.org (Postfix) with ESMTP id CDA716E553 for ; Wed, 18 Feb 2015 11:48:40 -0800 (PST) Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue103) with ESMTPSA (Nemesis) id 0Mch4z-1Y6mIo3xQX-00I06W; Wed, 18 Feb 2015 20:47:44 +0100 From: Arnd Bergmann To: David Airlie Subject: drm: bridge: ps8622 and ptn3460 depend on gpiolib Date: Wed, 18 Feb 2015 17:09:25 +0100 Message-ID: <19803561.otRxsE7o5u@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:4dwT5LatA/PE83RukRDoujxTMlLmgL4Y6o61IP0pWerrOTNTyww k9zDsQFgNT77r+evrFdg2UdRdZRBcHlMA2IpEOX/9jV1hMeRdLnqMnkX+FOcrx2m3IKUpH5 l8r28BBAPxhd/3NCHGb3FWAd72Wf8YLyFTAmto6v2MOOaIih2/qRZt17QDKA3uEFPfofAQz YnLsrUL3gtqSNLU+KSpLg== X-UI-Out-Filterresults: notjunk:1; Cc: Vincent Palatin , Andrew Bresticker , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Javier Martinez Canillas , Sjoerd Simons , Thierry Reding , Gustavo Padovan , Ajay Kumar , linux-arm-kernel@lists.infradead.org, Rahul Sharma X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DATE_IN_PAST_03_06, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The ptn3460 driver recently started usign the gpiod interface which is only available on platforms that come with GPIOLIB support, resulting in a compile-time error: drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable': drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] gpiod_set_value(ps8622->gpio_rst, 0); ^ drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe': drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration] ps8622->gpio_slp = devm_gpiod_get(dev, "sleep"); ^ Similarly, the newly added ps8622 driver started out with the same problem. This patch adds explicit Kconfig dependencies to avoid trying to build invalid configurations. Signed-off-by: Arnd Bergmann Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge") Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface") Reviewed-by: Javier Martinez Canillas diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index acef3223772c..8f068a0e86a5 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -7,6 +7,7 @@ config DRM_PTN3460 tristate "PTN3460 DP/LVDS bridge" depends on DRM depends on OF + depends on GPIOLIB select DRM_KMS_HELPER select DRM_PANEL ---help--- @@ -16,6 +17,7 @@ config DRM_PS8622 tristate "Parade eDP/LVDS bridge" depends on DRM depends on OF + depends on GPIOLIB select DRM_PANEL select DRM_KMS_HELPER select BACKLIGHT_LCD_SUPPORT