From patchwork Wed Oct 27 21:17:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 286662 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o9RLHkTb019816 for ; Wed, 27 Oct 2010 21:18:07 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B1619E7CC for ; Wed, 27 Oct 2010 14:17:46 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 151229E75F; Wed, 27 Oct 2010 14:17:35 -0700 (PDT) Received: by wwb39 with SMTP id 39so1118671wwb.12 for ; Wed, 27 Oct 2010 14:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=phhIKDEFpkLAWt9wAq6/ZanC1DU5cy0+wycQc9bJw98=; b=Z77N8TY4bpsSLs8fKFIS2CX8YvxGe55EG0zzXLdVCV2N231A7riiGUveLEB+c4SYOV bT1iakomyggUtzLGM6T4LDgh5f9Tz849LRBX+JQEi52uEynP6qmiVA9gfkyIgKCwLkPR SPGC93Li+jSNdi9iGfKQuxGgozEGkDzBj9kdg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=RazZyNuhHOUx1LKRRaACcQZr5sglGnMVhVLg/5JfzRxu74DN69a+X70FtHPKxDJYor gEVJ7Yb0Dub9OGq2cL59FPXVoaEox9FG5nl4fVPIaZ4E3xHYBRkorxk+hOXyR0PcM1gZ emVMUeMDkmegdly0ODOlynwYzc4iGaeXI9/kU= Received: by 10.216.173.79 with SMTP id u57mr1323422wel.40.1288214254874; Wed, 27 Oct 2010 14:17:34 -0700 (PDT) Received: from bicker (h2db5.n1.ips.mtn.co.ug [41.210.173.181]) by mx.google.com with ESMTPS id p4sm178259wej.28.2010.10.27.14.17.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 27 Oct 2010 14:17:34 -0700 (PDT) Date: Wed, 27 Oct 2010 23:17:25 +0200 From: Dan Carpenter To: Chris Wilson Subject: [patch] i915: signedness bug in check_overlay_src() Message-ID: <20101027211724.GI6062@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Wed, 27 Oct 2010 21:18:07 +0000 (UTC) diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/drm/i915/intel_overlay.c index afb96d2..02ff0a4 100644 --- a/drivers/gpu/drm/i915/intel_overlay.c +++ b/drivers/gpu/drm/i915/intel_overlay.c @@ -946,7 +946,9 @@ static int check_overlay_src(struct drm_device *dev, { int uv_hscale = uv_hsubsampling(rec->flags); int uv_vscale = uv_vsubsampling(rec->flags); - u32 stride_mask, depth, tmp; + u32 stride_mask; + int depth; + u32 tmp; /* check src dimensions */ if (IS_845G(dev) || IS_I830(dev)) {