From patchwork Fri Jan 21 08:23:23 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 494501 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p0L97krs001411 for ; Fri, 21 Jan 2011 09:08:06 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D6C939EF96 for ; Fri, 21 Jan 2011 01:07:45 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by gabe.freedesktop.org (Postfix) with ESMTP id 2921E9EF65 for ; Fri, 21 Jan 2011 00:26:22 -0800 (PST) Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id p0L8NTlR029871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 21 Jan 2011 00:23:29 -0800 Received: from localhost (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id p0L8NNJq030858; Fri, 21 Jan 2011 00:23:23 -0800 Date: Fri, 21 Jan 2011 00:23:23 -0800 From: Andrew Morton To: Geert Uytterhoeven Subject: Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock() Message-Id: <20110121002323.e9cbf9ae.akpm@linux-foundation.org> In-Reply-To: References: <1295539104-13210-1-git-send-email-torbenh@gmx.de> <20110120163448.GA30588@suse.de> <20110120165502.GA10832@siel.b> <20110120123507.ac89c034.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 X-Spam-Status: No, hits=-104.985 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED, PATCH_SUBJECT_OSDL, USER_IN_WHITELIST X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Mailman-Approved-At: Fri, 21 Jan 2011 01:02:35 -0800 Cc: Kevin Hilman , dri-devel@lists.freedesktop.org, Paul Mackerras , Panizzo , Phil Edworthy , Russell King , Tobias Schandinat , "James E.J. Bottomley" , Vlasenko , Kees Cook , Abhijeet Dharmapurikar , Rusty Russell , linux-geode@lists.infradead.org, Thomas Gleixner , linux-omap@vger.kernel.org, Girdwood , Daniel Walker , Linus Walleij , Geoff Levand , Kosina , linux-kernel@vger.kernel.org, Ralf Baechle , McMartin , Jiri@freedesktop.org, Werner@freedesktop.org, Takashi Iwai , Liam@freedesktop.org, linux-fbdev@vger.kernel.org, James Hogan , virtualization@lists.linux-foundation.org, Lars-Peter Clausen , Wu Zhangjin , Helge Deller , Kay Sievers , Ben Skeggs , Dave Airlie , Namhyung Kim , Tejun Heo , Magnus Damm , Daniel Mack , linux-arm-kernel@lists.infradead.org, Caglar Akyuz , Mark Brown , Paul Mundt , Morimoto , James Morris , Kuninori@freedesktop.org, Alberto@freedesktop.org, Denys@freedesktop.org, Thomas Gleixner , Tony Lindgren , Andres Salomon , Alexey Dobriyan , Arnd Bergmann , Fink , Nicolas Pitre , Dan Williams , Kyle@freedesktop.org, linux-parisc@vger.kernel.org, Greg KH , Ondrej Zajicek , Jean Delvare , "David S. Miller" , Florian@freedesktop.org, Daniel Vetter , Julia Lawall , Jiri Slaby , devel@driverdev.osuosl.org, xen-devel@lists.xensource.com, Lionel Debroux , David Brown , cbe-oss-dev@lists.ozlabs.org, Konrad Rzeszutek Wilk , torbenh , Jerome Glisse , Jeremy Fitzhardinge , Guy Martin , Jason Wessel , linuxppc-dev@lists.ozlabs.org, Guennadi Liakhovetski X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 21 Jan 2011 09:08:06 +0000 (UTC) --- a/kernel/printk.c~change-acquire-release_console_sem-to-console_lock-unlock-fix-2 +++ a/kernel/printk.c @@ -1058,7 +1058,7 @@ EXPORT_SYMBOL(console_lock); * Tried to acquire a lock which guarantees that the caller has * exclusive access to the console system and the console_drivers list. * - * returns -1 on success, and 0 on failure to acquire the lock. + * returns 1 on success, and 0 on failure to acquire the lock. */ int console_trylock(void) { @@ -1070,7 +1070,7 @@ int console_trylock(void) } console_locked = 1; console_may_schedule = 0; - return -1; + return 1; } EXPORT_SYMBOL(console_trylock);