| Message ID | 20110412041018.GC17720@siv.localdomain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Indeed, good catch. Luckily never ever used (libdrm takes care of it internally) in the drmCommand(Write|Read) functions. Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> On Tue, Apr 12, 2011 at 6:10 AM, Ole Henrik Jahren <olehenja@alumni.ntnu.no> wrote: > Signed-off-by: Ole Henrik Jahren <olehenja@alumni.ntnu.no> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > --- > > While adding DRM ioctl decoding support to strace, I noticed something > that looks very much like a typo. If it is intended this way, sorry > about the noise. > > include/drm/i915_drm.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h > index 0039f1f..ca7b8af 100644 > --- a/include/drm/i915_drm.h > +++ b/include/drm/i915_drm.h > @@ -237,7 +237,7 @@ typedef struct _drm_i915_sarea { > #define DRM_IOCTL_I915_GEM_GET_APERTURE DRM_IOR (DRM_COMMAND_BASE + DRM_I915_GEM_GET_APERTURE, struct drm_i915_gem_get_aperture) > #define DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GET_PIPE_FROM_CRTC_ID, struct drm_i915_get_pipe_from_crtc_id) > #define DRM_IOCTL_I915_GEM_MADVISE DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_MADVISE, struct drm_i915_gem_madvise) > -#define DRM_IOCTL_I915_OVERLAY_PUT_IMAGE DRM_IOW(DRM_COMMAND_BASE + DRM_IOCTL_I915_OVERLAY_ATTRS, struct drm_intel_overlay_put_image) > +#define DRM_IOCTL_I915_OVERLAY_PUT_IMAGE DRM_IOW(DRM_COMMAND_BASE + DRM_I915_OVERLAY_PUT_IMAGE, struct drm_intel_overlay_put_image) > #define DRM_IOCTL_I915_OVERLAY_ATTRS DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_OVERLAY_ATTRS, struct drm_intel_overlay_attrs) > > /* Allow drivers to submit batchbuffers directly to hardware, relying > -- > 1.7.5.rc1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >
diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 0039f1f..ca7b8af 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -237,7 +237,7 @@ typedef struct _drm_i915_sarea { #define DRM_IOCTL_I915_GEM_GET_APERTURE DRM_IOR (DRM_COMMAND_BASE + DRM_I915_GEM_GET_APERTURE, struct drm_i915_gem_get_aperture) #define DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GET_PIPE_FROM_CRTC_ID, struct drm_i915_get_pipe_from_crtc_id) #define DRM_IOCTL_I915_GEM_MADVISE DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_MADVISE, struct drm_i915_gem_madvise) -#define DRM_IOCTL_I915_OVERLAY_PUT_IMAGE DRM_IOW(DRM_COMMAND_BASE + DRM_IOCTL_I915_OVERLAY_ATTRS, struct drm_intel_overlay_put_image) +#define DRM_IOCTL_I915_OVERLAY_PUT_IMAGE DRM_IOW(DRM_COMMAND_BASE + DRM_I915_OVERLAY_PUT_IMAGE, struct drm_intel_overlay_put_image) #define DRM_IOCTL_I915_OVERLAY_ATTRS DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_OVERLAY_ATTRS, struct drm_intel_overlay_attrs) /* Allow drivers to submit batchbuffers directly to hardware, relying
Signed-off-by: Ole Henrik Jahren <olehenja@alumni.ntnu.no> Cc: Chris Wilson <chris@chris-wilson.co.uk> --- While adding DRM ioctl decoding support to strace, I noticed something that looks very much like a typo. If it is intended this way, sorry about the noise. include/drm/i915_drm.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)