From patchwork Mon Jun 27 13:32:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 920682 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p5RDWtkW011807 for ; Mon, 27 Jun 2011 13:33:15 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A5CE59F36E for ; Mon, 27 Jun 2011 06:32:54 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from services.gcu-squad.org (zone0.gcu-squad.org [212.85.147.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 411B89E7D9 for ; Mon, 27 Jun 2011 06:32:42 -0700 (PDT) Received: from jdelvare.pck.nerim.net ([62.212.121.182] helo=endymion.delvare) by services.gcu-squad.org (GCU Mailer Daemon) with esmtpsa id 1QbD4f-000206-3S (TLSv1:AES128-SHA:128) (envelope-from ) ; Mon, 27 Jun 2011 16:46:05 +0200 Date: Mon, 27 Jun 2011 15:32:34 +0200 From: Jean Delvare To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm: Fix EDID dump format Message-ID: <20110627153234.6bea33aa@endymion.delvare> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.20.1; x86_64-unknown-linux-gnu) Mime-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 27 Jun 2011 13:33:15 +0000 (UTC) * print_hex_dump_bytes() already includes a log level, so we shouldn't add one. That log level is KERN_DEBUG so use the same for our header for consistency. * print_hex_dump_bytes() properly puts a newline at the end of the last line, so there is no reason why we would add another one. Signed-off-by: Jean Delvare Cc: David Airlie --- drivers/gpu/drm/drm_edid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-3.0-rc4.orig/drivers/gpu/drm/drm_edid.c 2011-06-22 16:55:11.000000000 +0200 +++ linux-3.0-rc4/drivers/gpu/drm/drm_edid.c 2011-06-27 15:11:53.000000000 +0200 @@ -184,9 +184,9 @@ drm_edid_block_valid(u8 *raw_edid) bad: if (raw_edid) { - printk(KERN_ERR "Raw EDID:\n"); - print_hex_dump_bytes(KERN_ERR, DUMP_PREFIX_NONE, raw_edid, EDID_LENGTH); - printk(KERN_ERR "\n"); + printk(KERN_DEBUG "Raw EDID:\n"); + print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, + raw_edid, EDID_LENGTH); } return 0; }