From patchwork Wed Jul 6 14:24:11 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: bugzilla-daemon@freedesktop.org X-Patchwork-Id: 949792 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p66EOK4q028551 for ; Wed, 6 Jul 2011 14:24:41 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DEBEA9E7F0 for ; Wed, 6 Jul 2011 07:24:19 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from annarchy.freedesktop.org (annarchy.freedesktop.org [131.252.210.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 155F39E7F0 for ; Wed, 6 Jul 2011 07:24:12 -0700 (PDT) Received: by annarchy.freedesktop.org (Postfix, from userid 33) id CAE0213004F; Wed, 6 Jul 2011 07:24:11 -0700 (PDT) From: bugzilla-daemon@freedesktop.org To: dri-devel@lists.freedesktop.org Subject: [Bug 38800] glXSwapBuffersMscOML is slow on AMD Fusion but not on Intel 945 w/Atom X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Mesa X-Bugzilla-Component: Drivers/Gallium/r600 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: simon.farnsworth@onelan.co.uk X-Bugzilla-Status: NEW X-Bugzilla-Priority: medium X-Bugzilla-Assigned-To: dri-devel@lists.freedesktop.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 Message-Id: <20110706142411.CAE0213004F@annarchy.freedesktop.org> Date: Wed, 6 Jul 2011 07:24:11 -0700 (PDT) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Wed, 06 Jul 2011 14:24:41 +0000 (UTC) https://bugs.freedesktop.org/show_bug.cgi?id=38800 --- Comment #20 from Simon Farnsworth 2011-07-06 07:24:10 PDT --- So, this is a gross hack to demonstrate that it's the delaying of the pageflip that's hurting me: [sfarnsworth@f12simon airlied-drm-fixes]$ git diff pflip_cleanup2: With this bit of evil in place, I get 60fps at 1920x1200. diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 292f73f..b3c5630 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -475,6 +475,13 @@ static int radeon_crtc_page_flip(struct drm_crtc *crtc, /* fire the ring */ radeon_ring_unlock_commit(rdev); + spin_lock_irqsave(&dev->event_lock, flags); + if (!radeon_crtc->deferred_flip_completion) { + radeon_page_flip(rdev, radeon_crtc->crtc_id, work->new_crtc_base); + radeon_crtc->deferred_flip_completion = 1; + } + spin_unlock_irqrestore(&dev->event_lock, flags); + return 0;