From patchwork Sat Oct 20 22:19:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marcin_=C5=9Alusarz?= X-Patchwork-Id: 1622141 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 9391640135 for ; Sat, 20 Oct 2012 22:19:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8599E9EB99 for ; Sat, 20 Oct 2012 15:19:38 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C4C19E7A8 for ; Sat, 20 Oct 2012 15:19:25 -0700 (PDT) Received: by mail-wg0-f43.google.com with SMTP id dq11so1044266wgb.12 for ; Sat, 20 Oct 2012 15:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=yRtQmSPStlGzALMfmsVGCD+5/YIADzp53NkaWCD0z1k=; b=xa2XeSCMapUm/1Zl/L3mAgj4SVpcv9TBJa9jSXo36ejLZA4bT+N0vw0nWOSlm3+mlD AJxNH5XKBFmrQotzKv5YJ2cDj4RIjBBbu9Bujn37fha83jtfLa0RMLrdXg8FLC2rHowH o35rIt750p1owzwySmDLhsBJqx3L8DRS+aOfdVuDH1VYYllBNCTBBLvVmfsWokkxSH8H aQAYPa2sr75M2F5eAfFxqUhUxoD7MZca9KLfErFp6aD9lv8NsxbAHAbH4X/TzeflYMlC iYkxGXhUemcl8EHqcwT4p1PVAQ+DQ/XHkDpMuX/nPIUOZMlIJYsUWhQUuQpwJVef4+HZ hAUw== Received: by 10.180.85.99 with SMTP id g3mr11417600wiz.5.1350771564633; Sat, 20 Oct 2012 15:19:24 -0700 (PDT) Received: from joi.lan (acdo110.neoplus.adsl.tpnet.pl. [83.9.164.110]) by mx.google.com with ESMTPS id k20sm42688935wiv.11.2012.10.20.15.19.22 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 20 Oct 2012 15:19:23 -0700 (PDT) Date: Sun, 21 Oct 2012 00:19:48 +0200 From: Marcin Slusarz To: Heinz Diehl Subject: Re: Linux 3.7-rc1 (nouveau_bios_score oops). Message-ID: <20121020221948.GE5826@joi.lan> References: <1724445.dN2yMEzN6d@localhost> <20121020092647.GA3186@fancy-poultry.org> <50827174.7070109@labri.fr> <20121020104238.GA1539@fritha.org> <20121020202846.GA5826@joi.lan> <20121020212036.GA1698@fritha.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20121020212036.GA1698@fritha.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Martin Peres , =?utf-8?B?UGF3ZcWC?= Sikora , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs , marcheu@chromium.org, Linus Torvalds , Heinz Diehl X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > On 20.10.2012, Marcin Slusarz wrote: > > > Try this one. > > It works, now I can boot again. However, nouveau seems to be dead now. > The dmesg output with your patch on top of 3.7-rc1 is: > > [ 3.685909] [drm] Initialized i915 1.6.0 20080730 for 0000:00:02.0 on minor 0 > [ 3.687784] nouveau [ DEVICE][0000:01:00.0] BOOT0 : 0x0a8800b1 > [ 3.689960] nouveau [ DEVICE][0000:01:00.0] Chipset: GT218 (NVA8) > [ 3.692471] nouveau [ DEVICE][0000:01:00.0] Family : NV50 > [ 3.695716] nouveau [ VBIOS][0000:01:00.0] checking PRAMIN for image... > [ 3.697087] nouveau [ VBIOS][0000:01:00.0] ... signature not found > [ 3.698471] nouveau [ VBIOS][0000:01:00.0] checking PROM for image... > [ 3.699838] nouveau [ VBIOS][0000:01:00.0] ... signature not found > [ 3.701223] nouveau [ VBIOS][0000:01:00.0] checking ACPI for image... > [ 3.702684] ACPI Error: Field [ROMI] Base+Offset+Width 0+24+1 is beyond end of region [VROM] (length 24) (20120913/exfldio-210) > [ 3.704139] ACPI Error: Method parse/execution failed[\_SB_.PCI0.PEG1.GFX0._ROM] (Node ffff880142e85cf8), AE_AML_REGION_LIMIT (20120913/psparse-536) > [ 3.716183] failed to evaluate ROM got AE_AML_REGION_LIMIT > [ 3.718776] nouveau [ VBIOS][0000:01:00.0] ... signature not found > [ 3.721349] nouveau [ VBIOS][0000:01:00.0] checking PCIROM for image... > [ 3.724111] nouveau 0000:01:00.0: Invalid ROM contents > [ 3.726663] nouveau [ VBIOS][0000:01:00.0] ... signature not found > [ 3.729159] nouveau E[ VBIOS][0000:01:00.0] unable to locate usable image > [ 3.731677] nouveau E[ DEVICE][0000:01:00.0] failed to create 0x10000001, -22 > [ 3.734231] nouveau E[ DRM] failed to create 0x80000080, -22 > [ 3.736097] nouveau: probe of 0000:01:00.0 failed with error -22 > [ 3.740523] dracut: Starting plymouth daemon Hmm, maybe we can't fetch 3 bytes only... Let's check this: --- --- Please attach acpidump output. diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/base.c b/drivers/gpu/drm/nouveau/core/subdev/bios/base.c index 824eea0..8bd71aa 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/bios/base.c +++ b/drivers/gpu/drm/nouveau/core/subdev/bios/base.c @@ -192,14 +192,16 @@ nouveau_bios_shadow_acpi(struct nouveau_bios *bios) { struct pci_dev *pdev = nv_device(bios)->pdev; int ret, cnt, i; - u8 data[3]; + u8 *data; if (!nouveau_acpi_rom_supported(pdev)) return; bios->size = 0; - if (nouveau_acpi_get_bios_chunk(data, 0, 3) == 3) + data = kmalloc(4096, GFP_KERNEL); + if (data && nouveau_acpi_get_bios_chunk(data, 0, 4096) >= 3) bios->size = data[2] * 512; + kfree(data); if (!bios->size) return;