| Message ID | 20130701215738.GA519@x4 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: Markus Trippelsdorf [mailto:markus@trippelsdorf.de] > Sent: Monday, July 01, 2013 5:58 PM > To: alexdeucher@gmail.com > Cc: dri-devel@lists.freedesktop.org; airlied@gmail.com; Deucher, Alexander > Subject: Re: [pull] radeon drm-next-3.11 > > On 2013.07.01 at 17:01 -0400, alexdeucher@gmail.com wrote: > > From: Alex Deucher <alexander.deucher@amd.com> > > > > Hi Dave, > > > > A few more patches for 3.11: > > - add debugfs interface to check current DPM state > > - Fix a bug that caused problems with DPM on BTC+ asics. > > > > The following changes since commit > f7d452f4fd5d86f764807a1234a407deb5b105ef: > > > > Merge branch 'drm-nouveau-next' of > git://anongit.freedesktop.org/git/nouveau/linux-2.6 into drm-next (2013-07- > 01 14:10:20 +1000) > > > > are available in the git repository at: > > > > git://people.freedesktop.org/~agd5f/linux drm-next-3.11 > > > > Alex Deucher (12): > > drm/radeon: remove sumo dpm/uvd bringup leftovers > > drm/radeon/atom: fix endian bug in radeon_atom_init_mc_reg_table() > > drm/radeon: fix typo in radeon_atom_init_mc_reg_table() > > drm/radeon/dpm: re-enable state transitions for BTC > > drm/radeon/dpm: re-enable state transitions for Cayman > > drm/radeon/dpm: add infrastructure to support debugfs info > > drm/radeon/dpm: add debugfs support for rv6xx > > drm/radeon/dpm: add debugfs support for 7xx/evergreen/btc > > Looks like you forgot to add debugfs support for rs780: > > diff --git a/drivers/gpu/drm/radeon/radeon_asic.c > b/drivers/gpu/drm/radeon/radeon_asic.c > index a5b244d..ca4f928 100644 > --- a/drivers/gpu/drm/radeon/radeon_asic.c > +++ b/drivers/gpu/drm/radeon/radeon_asic.c > @@ -1270,6 +1270,7 @@ static struct radeon_asic rs780_asic = { > .get_sclk = &rs780_dpm_get_sclk, > .get_mclk = &rs780_dpm_get_mclk, > .print_power_state = &rs780_dpm_print_power_state, > + .debugfs_print_current_performance_level = > &rv770_dpm_debugfs_print_current_performance_level, > }, > .pflip = { > .pre_page_flip = &rs600_pre_page_flip, > Rs780 doesn't have a convenient way to look up the current power state so it's not implemented yet. The method used on the other asics does not work for rs780. Alex
diff --git a/drivers/gpu/drm/radeon/radeon_asic.c b/drivers/gpu/drm/radeon/radeon_asic.c index a5b244d..ca4f928 100644 --- a/drivers/gpu/drm/radeon/radeon_asic.c +++ b/drivers/gpu/drm/radeon/radeon_asic.c @@ -1270,6 +1270,7 @@ static struct radeon_asic rs780_asic = { .get_sclk = &rs780_dpm_get_sclk, .get_mclk = &rs780_dpm_get_mclk, .print_power_state = &rs780_dpm_print_power_state, + .debugfs_print_current_performance_level = &rv770_dpm_debugfs_print_current_performance_level, }, .pflip = { .pre_page_flip = &rs600_pre_page_flip,