From patchwork Fri Jul 12 16:25:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylvain 'ythier' Hitier X-Patchwork-Id: 2827002 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AFDCB9F7D6 for ; Fri, 12 Jul 2013 16:28:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BEBA320148 for ; Fri, 12 Jul 2013 16:28:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id A1AF220144 for ; Fri, 12 Jul 2013 16:28:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91714E680B for ; Fri, 12 Jul 2013 09:28:32 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E5B3E6817 for ; Fri, 12 Jul 2013 09:26:06 -0700 (PDT) Received: by mail-wi0-f174.google.com with SMTP id k10so887831wiv.7 for ; Fri, 12 Jul 2013 09:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Y/YdfN+oSjDjD3t8QGdyFrHjJomkrt/DL1VfL6Sk+0k=; b=c+xF0lobNgFBBk5LGSOOsuM68PBknL7ag8UsyBP0Cx3EPv7P+O7A4Y4U/KTyqAfqwT 25Cy5IpF47hyclS/j7S+ljBBc78U6ehp5ppDaGNsict2UpFgNHVpGy5GnqxwQLH6Zwc3 fowo0HMgJqp93taSkKmZLeWtmlGzt38yUyw5/EmyRn8G9n8JJD8Rmuj59efhKI8UfXdu Q/WD8q4bSIfJA1TzgB2hx3713BqW5Nm6QrCtDKWDRmM6RbaXUAneWWDSf85zq1HvwZ77 dRF0lsKmOtt/Rj5zCCPlYDuAfPxQGqt7cx1x09mc06kn89BGEZl97LTeLFhuPWnQKO0h /ILg== X-Received: by 10.194.157.65 with SMTP id wk1mr24305177wjb.8.1373646365268; Fri, 12 Jul 2013 09:26:05 -0700 (PDT) Received: from begonia (lns-bzn-37-82-253-6-128.adsl.proxad.net. [82.253.6.128]) by mx.google.com with ESMTPSA id i1sm4397401wiz.6.2013.07.12.09.26.03 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 12 Jul 2013 09:26:04 -0700 (PDT) Date: Fri, 12 Jul 2013 18:25:54 +0200 From: Sylvain 'ythier' Hitier To: Andy Lutomirski Subject: [PATCH] uvesafb: Really allow mtrr being 0, as documented and warn()ed Message-ID: <20130712162554.GA3789@begonia> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Dave Airlie , DRI mailing list , Torsten Kaiser X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, When: 2013-07-10_3@10-36-22 -0700 Who: Andy Lutomirski What: > On Wed, Jul 10, 2013 at 10:07 AM, Torsten Kaiser > wrote: > > Commit 63e28a7a5ffce59b645ca9cbcc01e1e8be56bd75, "uvesafb: Clean up > > MTRR code" contains the following change: > > > > @@ -1930,6 +1891,9 @@ static int uvesafb_setup(char *options) > > } > > } > > > > + if (mtrr != 3 && mtrr != 1) > > + pr_warn("uvesafb: mtrr should be set to 0 or 3; %d is > > unsupported", mtrr); > > + > > return 0; > > } > > #endif /* !MODULE */ > > > > Shouldn't this be && mtrr != 0? > > Indeed, and Sylvain Hitier (cc'd) sent a patch (off-list) that must > have gotten lost somewhere. RIP patch born on 2013-06-08_6@23-02-26 +0200 ... May your soul be happy, because here is a clone of you who will hopefully fulfill your quest: Fixup for commit "uvesafb: Clean up MTRR code" (63e28a7a5ffce59b645ca9cbcc01e1e8be56bd75) Signed-off-by: Sylvain "ythier" Hitier Acked-by: Andy Lutomirski Also-spotted-by: Torsten Kaiser --- drivers/video/uvesafb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Regards, Sylvain "ythier" Hitier diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c index 296279b..2121fc3 100644 --- a/drivers/video/uvesafb.c +++ b/drivers/video/uvesafb.c @@ -1891,7 +1891,7 @@ static int uvesafb_setup(char *options) } } - if (mtrr != 3 && mtrr != 1) + if (mtrr != 3 && mtrr != 0) pr_warn("uvesafb: mtrr should be set to 0 or 3; %d is unsupported", mtrr); return 0;