| Message ID | 20130822124250.GA2543@elgon.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 22, 2013 at 8:42 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > We're taking the sizeof() the wrong thing so it doesn't clear the whole > buffer. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Oh, that was very certainly wrong before! Acked-by: Rob Clark <robdclark@gmail.com> > --- > I can't compile this. > > diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c > index 9b794c9..acf6678 100644 > --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c > +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c > @@ -871,7 +871,7 @@ int tiler_map_show(struct seq_file *s, void *arg) > goto error; > > for (lut_idx = 0; lut_idx < omap_dmm->num_lut; lut_idx++) { > - memset(map, 0, sizeof(h_adj * sizeof(*map))); > + memset(map, 0, h_adj * sizeof(*map)); > memset(global_map, ' ', (w_adj + 1) * h_adj); > > for (i = 0; i < omap_dmm->container_height; i++) {
diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c index 9b794c9..acf6678 100644 --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c @@ -871,7 +871,7 @@ int tiler_map_show(struct seq_file *s, void *arg) goto error; for (lut_idx = 0; lut_idx < omap_dmm->num_lut; lut_idx++) { - memset(map, 0, sizeof(h_adj * sizeof(*map))); + memset(map, 0, h_adj * sizeof(*map)); memset(global_map, ' ', (w_adj + 1) * h_adj); for (i = 0; i < omap_dmm->container_height; i++) {
We're taking the sizeof() the wrong thing so it doesn't clear the whole buffer. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- I can't compile this.