From patchwork Thu Oct 10 22:53:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King - ARM Linux X-Patchwork-Id: 3022121 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 55F5EBF924 for ; Fri, 11 Oct 2013 10:35:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 317E320278 for ; Fri, 11 Oct 2013 10:35:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 93D8F202A1 for ; Fri, 11 Oct 2013 10:34:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 92A6F43778 for ; Fri, 11 Oct 2013 03:34:58 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from caramon.arm.linux.org.uk (caramon.arm.linux.org.uk [78.32.30.218]) by gabe.freedesktop.org (Postfix) with ESMTP id A262DE7AFA for ; Thu, 10 Oct 2013 15:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=OG4it8M843i0xrBKFhbYCUH6XlU2RM+4Tl42BfF/xNA=; b=oZODtioG/xFrDIO0i2Kv1M0No2AVw0/M0MWiiJgRu65lFphR/xBO7NgQ5KWrzFByrqpP/2LLKykspx0J3GUC+DyWzjnJUllcjSq4gINfrFYfkJ3ILMrhjI6ue8pS3isHSKuSeh6S3Jwr9AE/VQsHyPDQQLqe/C+JTihfdbs/48I=; Received: from n2100.arm.linux.org.uk ([2002:4e20:1eda:1:214:fdff:fe10:4f86]:59213) by caramon.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1VUP6r-0006NR-RA; Thu, 10 Oct 2013 23:53:34 +0100 Received: from linux by n2100.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1VUP6q-0008B6-7Z; Thu, 10 Oct 2013 23:53:32 +0100 Date: Thu, 10 Oct 2013 23:53:31 +0100 From: Russell King - ARM Linux To: Rob Clark Subject: Re: [PATCH 2/5] DRM: Armada: Add Armada DRM driver Message-ID: <20131010225331.GT25034@n2100.arm.linux.org.uk> References: <20131006220728.GG12758@n2100.arm.linux.org.uk> <20131010215951.GS25034@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-Mailman-Approved-At: Fri, 11 Oct 2013 03:25:33 -0700 Cc: Jason Cooper , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , Sebastian Hesselbarth X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Oct 10, 2013 at 06:23:26PM -0400, Rob Clark wrote: > On Thu, Oct 10, 2013 at 5:59 PM, Russell King - ARM Linux > wrote: > > On Thu, Oct 10, 2013 at 05:25:15PM -0400, Rob Clark wrote: > >> probably this thread is applicable here too? > >> > >> https://lkml.org/lkml/2013/9/12/417 > >> > >> (although.. we have at least a few slightly differet variants on the > >> same errno -> VM_FAULT_x switch in different drivers.. maybe we should > >> do something better) > > > > Hmm. It seems today's vm_insert_pfn() has the following error return > > values: > > > > -EFAULT - virtual address outside vma > > -EINVAL - track_pfn_insert() failure > > -ENOMEM - failed to get locked pte > > -EBUSY - entry already exists in pte > > > > So it seems my handling -EIO, -EAGAIN, -ERESTARTSYS and -EINTR are all > > redundant and can be removed. I'm not sure if it makes sense for this > > to be generic - it looks like it's only Intel, gma500 and me who use > > this, and Intel handles more error codes (due to it calling other > > functions.) > > I just noticed msm and omapdrm are missing the -EBUSY case (have some > patches I need to send), which was why I mentioned this. They do have > other error cases from other fxns, so maybe something generic/common > doesn't make sense.. but I realized i915 fixed the same issue a while > back, so somewhere common has the advantage of somehow not forgetting > to fix other drivers ;-) Here's the promised delta: drivers/gpu/drm/armada/armada_gem.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c index 02de7a4..1e74f70 100644 --- a/drivers/gpu/drm/armada/armada_gem.c +++ b/drivers/gpu/drm/armada/armada_gem.c @@ -25,12 +25,7 @@ static int armada_gem_vm_fault(struct vm_area_struct *vma, struct vm_fault *vmf) ret = vm_insert_pfn(vma, addr, pfn); switch (ret) { - case -EIO: - case -EAGAIN: - set_need_resched(); case 0: - case -ERESTARTSYS: - case -EINTR: case -EBUSY: return VM_FAULT_NOPAGE; case -ENOMEM: