| Message ID | 20131108100803.GY27977@elgon.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Nov 08, 2013 at 01:08:03PM +0300, Dan Carpenter wrote: > I've shifted the __user markup to make Sparse happy. > > drivers/gpu/drm/tegra/drm.c:138:18: warning: incorrect type in initializer (different address spaces) > drivers/gpu/drm/tegra/drm.c:138:18: expected struct drm_tegra_cmdbuf [noderef] <asn:1>*cmdbufs > drivers/gpu/drm/tegra/drm.c:138:18: got void *[noderef] <asn:1><noident> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Hi Dan, I fixed exactly the same sparse warnings (along with many others this morning). We really ought to have a tag to put into a commit to credit people who've come up with the same patch at the same time. Thierry
On Fri, Nov 08, 2013 at 01:34:56PM +0100, Thierry Reding wrote: > On Fri, Nov 08, 2013 at 01:08:03PM +0300, Dan Carpenter wrote: > > I've shifted the __user markup to make Sparse happy. > > > > drivers/gpu/drm/tegra/drm.c:138:18: warning: incorrect type in initializer (different address spaces) > > drivers/gpu/drm/tegra/drm.c:138:18: expected struct drm_tegra_cmdbuf [noderef] <asn:1>*cmdbufs > > drivers/gpu/drm/tegra/drm.c:138:18: got void *[noderef] <asn:1><noident> > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Hi Dan, > > I fixed exactly the same sparse warnings (along with many others this > morning). We really ought to have a tag to put into a commit to credit > people who've come up with the same patch at the same time. No no. First come first serve. :) regards, dan carpenter
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index fd3ff3b..96a9207 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu/drm/tegra/drm.c @@ -135,11 +135,11 @@ int tegra_drm_submit(struct tegra_drm_context *context, unsigned int num_relocs = args->num_relocs; unsigned int num_waitchks = args->num_waitchks; struct drm_tegra_cmdbuf __user *cmdbufs = - (void * __user)(uintptr_t)args->cmdbufs; + (void __user *)(uintptr_t)args->cmdbufs; struct drm_tegra_reloc __user *relocs = - (void * __user)(uintptr_t)args->relocs; + (void __user *)(uintptr_t)args->relocs; struct drm_tegra_waitchk __user *waitchks = - (void * __user)(uintptr_t)args->waitchks; + (void __user *)(uintptr_t)args->waitchks; struct drm_tegra_syncpt syncpt; struct host1x_job *job; int err; @@ -207,7 +207,7 @@ int tegra_drm_submit(struct tegra_drm_context *context, goto fail; } - if (copy_from_user(&syncpt, (void * __user)(uintptr_t)args->syncpts, + if (copy_from_user(&syncpt, (void __user *)(uintptr_t)args->syncpts, sizeof(syncpt))) { err = -EFAULT; goto fail;
I've shifted the __user markup to make Sparse happy. drivers/gpu/drm/tegra/drm.c:138:18: warning: incorrect type in initializer (different address spaces) drivers/gpu/drm/tegra/drm.c:138:18: expected struct drm_tegra_cmdbuf [noderef] <asn:1>*cmdbufs drivers/gpu/drm/tegra/drm.c:138:18: got void *[noderef] <asn:1><noident> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>