From patchwork Tue Jan 20 00:25:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Mc Guire X-Patchwork-Id: 5661991 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C5FF49F6E4 for ; Tue, 20 Jan 2015 02:06:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 14A0E203AC for ; Tue, 20 Jan 2015 02:06:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 358DA2035B for ; Tue, 20 Jan 2015 02:06:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D24B76E188; Mon, 19 Jan 2015 18:05:56 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 436 seconds by postgrey-1.34 at gabe; Mon, 19 Jan 2015 16:32:30 PST Received: from mail.hofr.at (hofr.at [212.69.189.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C36F6E12C for ; Mon, 19 Jan 2015 16:32:30 -0800 (PST) Received: by mail.hofr.at (Postfix, from userid 1002) id C9A244F8342; Tue, 20 Jan 2015 01:25:11 +0100 (CET) Date: Tue, 20 Jan 2015 01:25:11 +0100 From: Nicholas Mc Guire To: "Deucher, Alexander" Subject: Re: [PATCH] drm/radeon: remove unreachable code Message-ID: <20150120002511.GA19484@opentech.at> References: <1421673040-12305-1-git-send-email-der.herr@hofr.at> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Mailman-Approved-At: Mon, 19 Jan 2015 18:05:56 -0800 Cc: "Koenig, Christian" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 19 Jan 2015, Deucher, Alexander wrote: > > -----Original Message----- > > From: Nicholas Mc Guire [mailto:der.herr@hofr.at] > > Sent: Monday, January 19, 2015 8:11 AM > > To: Deucher, Alexander > > Cc: Koenig, Christian; David Airlie; dri-devel@lists.freedesktop.org; linux- > > kernel@vger.kernel.org; Nicholas Mc Guire > > Subject: [PATCH] drm/radeon: remove unreachable code > > > > Signed-off-by: Nicholas Mc Guire > > NACK. I want to leave this in place for the future. When we support dynamically adjusting the disp clock we'll need to update the sclk for ds mode. > get it - then could you add some comment to that end so it becomes clear that this is intentional - using your comment above - something like: From 2be978edbc77d5928ede8fddc2d784ca6f78533e Mon Sep 17 00:00:00 2001 From: Nicholas Mc Guire Date: Mon, 19 Jan 2015 19:11:57 -0500 Subject: [PATCH] document the unreachable code sequence Signed-off-by: Nicholas Mc Guire --- drivers/gpu/drm/radeon/ci_dpm.c | 7 +++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c index f373a81..722dfef 100644 --- a/drivers/gpu/drm/radeon/ci_dpm.c +++ b/drivers/gpu/drm/radeon/ci_dpm.c @@ -3808,7 +3808,12 @@ static void ci_find_dpm_states_clocks_in_dpm_table(struct radeon_device *rdev, if (i >= sclk_table->count) { pi->need_update_smu7_dpm_table |= DPMTABLE_OD_UPDATE_SCLK; } else { - /* XXX check display min clock requirements */ + /* + * XXX Check display min clock requirements. + * This is a place holder for the future support of + * dynamically adjusting the disp clock where we'll + * need to update the sclk for ds mode. + */ if (CISLAND_MINIMUM_ENGINE_CLOCK != CISLAND_MINIMUM_ENGINE_CLOCK) pi->need_update_smu7_dpm_table |= DPMTABLE_UPDATE_SCLK; }