From patchwork Thu Jan 29 14:29:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 5742781 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0D52B9F358 for ; Thu, 29 Jan 2015 14:29:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2210120259 for ; Thu, 29 Jan 2015 14:29:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 2976520251 for ; Thu, 29 Jan 2015 14:29:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 79EE3720AF; Thu, 29 Jan 2015 06:29:25 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qg0-f47.google.com (mail-qg0-f47.google.com [209.85.192.47]) by gabe.freedesktop.org (Postfix) with ESMTP id F0E39720AF for ; Thu, 29 Jan 2015 06:29:23 -0800 (PST) Received: by mail-qg0-f47.google.com with SMTP id z60so28729949qgd.6 for ; Thu, 29 Jan 2015 06:29:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=uYXy3FJqSS9I4PR00TD1allOAGZgHMm+QSEasmCJ/SU=; b=ZOOYjzriRnFSJDJOccmZyJxuexkYd9lj8eB3XU6v7WcEYDP0WEP/Y55rz0DVwBOTPo 6lj8sRhu7mg0sjLA2E+TIxD0B0e+GQAKlPShLAq1GiRHY1oCcbAHzVdkTdse9wHr4pgN Bk3evc+yfhc40WCwoslXGgZP5I2FZz+P9p5Q+oFzshiUil5m0dg3adoiJwhftLq/hzr3 BGaM270wAuhdNGTi3zpRgRJhNZ7WaxmHu4SKoIzKNgRR5Ii4JRbebIVq4djOXLLYVpdW A2rp2oHcejqNO7Ofr/Fof3C2MsBH2bO2MC54QcKPUp+9bfuhNZP3VZf2f2vWtTLWhamb CajQ== X-Received: by 10.140.87.71 with SMTP id q65mr1338113qgd.67.1422541763331; Thu, 29 Jan 2015 06:29:23 -0800 (PST) Received: from localhost ([177.102.251.77]) by mx.google.com with ESMTPSA id w107sm510180qge.5.2015.01.29.06.29.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jan 2015 06:29:22 -0800 (PST) Date: Thu, 29 Jan 2015 12:29:19 -0200 From: Gustavo Padovan To: Ajay Kumar Subject: Re: [PATCH V9 04/14] drm/bridge: ptn3460: Convert to i2c driver model Message-ID: <20150129142919.GN2001@joana> References: <1421771935-31618-1-git-send-email-ajaykumar.rs@samsung.com> <1421771935-31618-5-git-send-email-ajaykumar.rs@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1421771935-31618-5-git-send-email-ajaykumar.rs@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: devicetree@vger.kernel.org, kgene.kim@samsung.com, seanpaul@google.com, daniel.vetter@ffwll.ch, jg1.han@samsung.com, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, ajaynumb@gmail.com, bhushan.r@samsung.com, prashanth.g@samsung.com, linux-arm-kernel@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Ajay, 2015-01-20 Ajay Kumar : > Use drm_bridge helpers to modify the driver to support > i2c driver model. > > Signed-off-by: Ajay Kumar > Acked-by: Inki Dae > Tested-by: Rahul Sharma > Tested-by: Javier Martinez Canillas > Tested-by: Gustavo Padovan > Tested-by: Sjoerd Simons > --- > drivers/gpu/drm/bridge/Kconfig | 2 + > drivers/gpu/drm/bridge/ptn3460.c | 124 +++++++++++++++++++++---------- > drivers/gpu/drm/exynos/exynos_dp_core.c | 22 ------ > 3 files changed, 86 insertions(+), 62 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 884923f..4254c2b 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -1,5 +1,7 @@ > config DRM_PTN3460 > tristate "PTN3460 DP/LVDS bridge" > depends on DRM > + depends on OF && I2C Adding I2C here is causing this circular dependency: scripts/kconfig/conf --silentoldconfig Kconfig drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34: symbol DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER drivers/gpu/drm/Kconfig:28: symbol DRM_KMS_HELPER is selected by DRM_PTN3460 drivers/gpu/drm/bridge/Kconfig:1: symbol DRM_PTN3460 depends on I2C drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59: symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374: symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362: symbol FB_CYBER2000 depends on FB To solve this we just need to remove I2C from depends as DRM already selects I2C. This was already fixed by: commit 90bde571ad194adb039cb92a11a5b346f15eb610 Author: Arnd Bergmann Date: Tue Mar 25 12:06:46 2014 +0100 drm/bridge: PTN3460 needs DRM_KMS_HELPER The recently added PTN3460 device driver uses interfaces that are provided by the KMS helper infrastructure, so we should explicitly select that to avoid this linker error: ERROR: "drm_helper_probe_single_connector_modes" [drivers/gpu/drm/bridge/ptn3460.ko] undefined! ERROR: "drm_helper_connector_dpms" [drivers/gpu/drm/bridge/ptn3460.ko] undefined! We have to drop the I2C dependency to avoid a circular dependency chain, but that's ok because DRM already selects I2C. Signed-off-by: Arnd Bergmann Signed-off-by: Dave Airlie But you may have introduced it again on a rebase. The following patch fixes it: Gustavo diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 990b4b2..946d1ef 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -1,7 +1,6 @@ config DRM_PTN3460 tristate "PTN3460 DP/LVDS bridge" - depends on DRM - depends on OF && I2C + depends on DRM && OF select DRM_KMS_HELPER select DRM_PANEL ---help---