diff mbox

drm/exynos: IS_ERR() vs NULL bug

Message ID 20150220105443.GD7895@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter Feb. 20, 2015, 10:54 a.m. UTC 
of_iomap() doesn't return error pointers, it returns NULL on error.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Gustavo Padovan Feb. 20, 2015, 1:12 p.m. UTC | #1 
Hi Dan,

2015-02-20 Dan Carpenter <dan.carpenter@oracle.com>:

> of_iomap() doesn't return error pointers, it returns NULL on error.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> index 63f02e2..9700461 100644
> --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> @@ -888,8 +888,8 @@ static int decon_probe(struct platform_device *pdev)
>  	of_node_put(i80_if_timings);
>  
>  	ctx->regs = of_iomap(dev->of_node, 0);
> -	if (IS_ERR(ctx->regs)) {
> -		ret = PTR_ERR(ctx->regs);
> +	if (!ctx->regs) {
> +		ret = -ENOMEM;
>  		goto err_del_component;
>  	}

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

	Gustavo
Inki Dae March 6, 2015, 12:49 p.m. UTC | #2 
On 2015? 02? 20? 19:54, Dan Carpenter wrote:
> of_iomap() doesn't return error pointers, it returns NULL on error.

Applied.

Thanks,
Inki Dae

> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> index 63f02e2..9700461 100644
> --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> @@ -888,8 +888,8 @@ static int decon_probe(struct platform_device *pdev)
>  	of_node_put(i80_if_timings);
>  
>  	ctx->regs = of_iomap(dev->of_node, 0);
> -	if (IS_ERR(ctx->regs)) {
> -		ret = PTR_ERR(ctx->regs);
> +	if (!ctx->regs) {
> +		ret = -ENOMEM;
>  		goto err_del_component;
>  	}
>  
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
index 63f02e2..9700461 100644
--- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
@@ -888,8 +888,8 @@  static int decon_probe(struct platform_device *pdev)
 	of_node_put(i80_if_timings);
 
 	ctx->regs = of_iomap(dev->of_node, 0);
-	if (IS_ERR(ctx->regs)) {
-		ret = PTR_ERR(ctx->regs);
+	if (!ctx->regs) {
+		ret = -ENOMEM;
 		goto err_del_component;
 	}