From patchwork Tue Jun 30 16:59:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 6697551 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6C78BC05AC for ; Tue, 30 Jun 2015 16:57:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5BB9D2062C for ; Tue, 30 Jun 2015 16:57:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id CFFE42062B for ; Tue, 30 Jun 2015 16:57:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23D006E9EF; Tue, 30 Jun 2015 09:57:14 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id EAAD16E9EF for ; Tue, 30 Jun 2015 09:57:12 -0700 (PDT) Received: by wguu7 with SMTP id u7so15064968wgu.3 for ; Tue, 30 Jun 2015 09:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=c5PFV6IhLKdYTN+nSsFJq3UZbo8C6qa/VnbjdmDvpqU=; b=lD9ZVxbMJ0RGTpZOVjQ5yroq4jUuNfiKLiF/JDzuKjbGHiFIqQlpIJdBdqspJ4smQO qsmoghCsjXeFHC3P+SvGYf4DIKf3iWq6f9VIeu3WR7WnJggTROKF9M7NmI2D8JRjaNpU anTFLVMPvKOQImv9AALEYRh6/FZH36CzVLmn8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=c5PFV6IhLKdYTN+nSsFJq3UZbo8C6qa/VnbjdmDvpqU=; b=SjX3oQXpZFhGNgi8dYcZKahV0Ch7XKXVUIKvcBEkDzO97ROWpDr22amjw9OhtWbnTi NOVRlmj2xDoyA+y5MYvt0e9dpRBB82z+0patzJjGPdkY/qEErGMh4VIlRnW5UGH9EqAf JtJioEn+mKiRoP2PVHCw7XMsGiYIFfkaz2Y8eE5INawAu+LHJjt6NMgZPZ18RjmSw7VY ojYYJxneAJe4f/wEpIwAuFm/RYNTPmb6SC54WLFaPbIuzcx5yDTEwMxrReb/REFpUwT5 cbKXsRVpEDCzEzrFaSAS8DNKlpA/X4W51HRRxq0WHs+9tDMFDiIbGsAnLIBqzB8+zB5B Py1g== X-Gm-Message-State: ALoCoQkWD0QTnvfkExvXHQcuEwKKe/X5a5YSZ3XewvwwqODDj80OGXu+024/fHgMx5X6Cyl8prA9 X-Received: by 10.194.192.166 with SMTP id hh6mr39369569wjc.127.1435683431449; Tue, 30 Jun 2015 09:57:11 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by mx.google.com with ESMTPSA id b5sm17831486wic.3.2015.06.30.09.57.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jun 2015 09:57:10 -0700 (PDT) Date: Tue, 30 Jun 2015 18:59:29 +0200 From: Daniel Vetter To: Michal Hocko Subject: Re: WARNING: CPU: 0 PID: 3634 at drivers/gpu/drm/drm_irq.c:1141 drm_wait_one_vblank Message-ID: <20150630165929.GB30960@phenom.ffwll.local> Mail-Followup-To: Michal Hocko , David Airlie , dri-devel@lists.freedesktop.org, LKML References: <20150630115707.GA4578@dhcp22.suse.cz> <20150630143249.GA30960@phenom.ffwll.local> <20150630160743.GA4590@dhcp22.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150630160743.GA4590@dhcp22.suse.cz> X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dri-devel@lists.freedesktop.org, LKML X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Jun 30, 2015 at 06:07:44PM +0200, Michal Hocko wrote: > On Tue 30-06-15 16:32:49, Daniel Vetter wrote: > [...] > > Looks like the vblank is actually running, just the wakeup somehow doesn't > > happen in time. What machine is this (lspci -nn)? > > 00:00.0 Host bridge [0600]: Intel Corporation 2nd Generation Core Processor Family DRAM Controller [8086:0104] (rev 09) > 00:02.0 VGA compatible controller [0300]: Intel Corporation 2nd Generation Core Processor Family Integrated Graphics Controller [8086:0126] (rev 09) > 00:16.0 Communication controller [0780]: Intel Corporation 6 Series/C200 Series Chipset Family MEI Controller #1 [8086:1c3a] (rev 04) > 00:16.3 Serial controller [0700]: Intel Corporation 6 Series/C200 Series Chipset Family KT Controller [8086:1c3d] (rev 04) > 00:19.0 Ethernet controller [0200]: Intel Corporation 82579LM Gigabit Network Connection [8086:1502] (rev 04) > 00:1a.0 USB controller [0c03]: Intel Corporation 6 Series/C200 Series Chipset Family USB Enhanced Host Controller #2 [8086:1c2d] (rev 04) > 00:1b.0 Audio device [0403]: Intel Corporation 6 Series/C200 Series Chipset Family High Definition Audio Controller [8086:1c20] (rev 04) > 00:1c.0 PCI bridge [0604]: Intel Corporation 6 Series/C200 Series Chipset Family PCI Express Root Port 1 [8086:1c10] (rev b4) > 00:1c.1 PCI bridge [0604]: Intel Corporation 6 Series/C200 Series Chipset Family PCI Express Root Port 2 [8086:1c12] (rev b4) > 00:1c.2 PCI bridge [0604]: Intel Corporation 6 Series/C200 Series Chipset Family PCI Express Root Port 3 [8086:1c14] (rev b4) > 00:1c.3 PCI bridge [0604]: Intel Corporation 6 Series/C200 Series Chipset Family PCI Express Root Port 4 [8086:1c16] (rev b4) > 00:1c.5 PCI bridge [0604]: Intel Corporation 6 Series/C200 Series Chipset Family PCI Express Root Port 6 [8086:1c1a] (rev b4) > 00:1d.0 USB controller [0c03]: Intel Corporation 6 Series/C200 Series Chipset Family USB Enhanced Host Controller #1 [8086:1c26] (rev 04) > 00:1f.0 ISA bridge [0601]: Intel Corporation QM67 Express Chipset Family LPC Controller [8086:1c4f] (rev 04) > 00:1f.2 SATA controller [0106]: Intel Corporation 6 Series/C200 Series Chipset Family 6 port SATA AHCI Controller [8086:1c03] (rev 04) > 00:1f.3 SMBus [0c05]: Intel Corporation 6 Series/C200 Series Chipset Family SMBus Controller [8086:1c22] (rev 04) > 02:00.0 Network controller [0280]: Intel Corporation Centrino Ultimate-N 6300 [8086:422b] (rev 35) > 0a:00.0 SD Host controller [0805]: O2 Micro, Inc. OZ600FJ0/OZ900FJ0/OZ600FJS SD/MMC Card Reader Controller [1217:8221] (rev 05) > > > Also please boot with > > drm.debug=0xe and grab dmesg after this happens for the first time. > > logfile will be large, you might need to increase the buffer size with > > log_buf_len or grab it from the hd. > > See attached. > > > Also what happens when you increase the timeout to 1000 (just to make sure > > it's not just a silly delay somewhere). > > Still happening even when the timeout was increased to 1000. Curiously > the display is much darker with this change and I cannot make it > brighter by function keys... > > > Also have you any special features like psr, fbc or something similar > > enabled? > > I am not aware of anything like that. How do I check it? I looked at dmesg, nothing out of the ordinary there. Unfortunately also no hints why the pipe is somehow off when we think it's on. Can you please test the below patch and grab a new dmesg? Also it might be time to start bisecting this if you can readily reproduce it. -Daniel diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index d0f3cbc87474..b8d9314ef459 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -12190,7 +12190,7 @@ static int intel_crtc_set_config(struct drm_mode_set *set) * flipping, so increasing its cost here shouldn't be a big * deal). */ - if (i915.fastboot && ret == 0) + if (ret == 0) intel_modeset_check_state(set->crtc->dev); }