From patchwork Mon Sep 14 10:29:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 7174461 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A8B2D9F326 for ; Mon, 14 Sep 2015 10:30:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0FD4020619 for ; Mon, 14 Sep 2015 10:30:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 1980F20544 for ; Mon, 14 Sep 2015 10:30:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D08C6E010; Mon, 14 Sep 2015 03:30:02 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 376C76E010 for ; Mon, 14 Sep 2015 03:30:01 -0700 (PDT) Received: by padhk3 with SMTP id hk3so140649830pad.3 for ; Mon, 14 Sep 2015 03:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=05EWIi3eklve/GsrlgM1CosVWpJ0+m8DfLHsUVTWHp0=; b=TpnqDdk1kW3unacfo1YmCn/D9Kgr4wqP5MoDc1tKcfLb/4YDgtKyrr8KY9AqSPXI/e U/rSrfta44JoJS43r+mNzd9TSKh77EmSzNk4FiYRSOspeSbblwPMsB23+kF6JWpHfe3Y EN6VcB2ZzJhk1ngIBC8K4BAD2BNpLn2NsO9kCt8+iZVthyuidKjD7M8tnpSoRHw4cYRR ZCfhxXMhYrHkYuYrqcO3Nj8zpPkjV1lF1BsMdkp8rRC6avpjkzLVsKjn6q/e0sUBNcAZ FcA2AQU3O3a3cXXm1R1efskZkpLU5XB259fUBH9xJ04V/IHktEwp6uYfYTJLPmTEc0dp DlLA== X-Received: by 10.68.137.202 with SMTP id qk10mr33401136pbb.30.1442226600740; Mon, 14 Sep 2015 03:30:00 -0700 (PDT) Received: from sudip-pc ([49.206.249.64]) by smtp.gmail.com with ESMTPSA id yt9sm15416521pac.32.2015.09.14.03.29.57 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 14 Sep 2015 03:30:00 -0700 (PDT) Date: Mon, 14 Sep 2015 15:59:51 +0530 From: Sudip Mukherjee To: Dave Airlie Subject: Re: [PATCH] drm/mgag200: fix memory leak Message-ID: <20150914102951.GA23251@sudip-pc> References: <1441627110-13783-1-git-send-email-sudipm.mukherjee@gmail.com> <20150913093607.GA6074@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Daniel Vetter , LKML , dri-devel , Archit Taneja , Ingo Molnar X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Sep 14, 2015 at 08:05:37PM +1000, Dave Airlie wrote: > (this time with correct email address). > > On 14 September 2015 at 20:04, Dave Airlie wrote: > >> > >> > >> There's a new regression: v4.3-rc1 crashes on bootup on non-supported hardware, if > >> CONFIG_DRM_MGAG200=y (built into the kernel). > > > > Archit, I'm guessing this is some fallout from the fbdev changes. > > > > There is no reason we should need CONFIG_FB_LITTLE_ENDIAN I don't think. I am assuming v4.2 has worked for Ingo. So in that case I don't see any change in fbdev/core/fbmem.c between 4.2 and 4.3-rc1. But in drm (I almost know nothing about drm) commit e829d7ef9f17 changes few codes related to the card revision. Can this help? regards sudip diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index c99d3fe..5cdfa53 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -1602,7 +1602,7 @@ static int mga_vga_mode_valid(struct drm_connector *connector, if (mga_vga_calculate_mode_bandwidth(mode, bpp) > (24400 * 1024)) return MODE_BANDWIDTH; - } else if (mdev->unique_rev_id == 0x02) { + } else if (mdev->unique_rev_id >= 0x02) { if (mode->hdisplay > 1920) return MODE_VIRTUAL_X; if (mode->vdisplay > 1200)