Message ID | 20160120095352.GA19898@mwanda (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi Dan, Am Mittwoch, 20. Januar 2016, 12:53:52 schrieb Dan Carpenter: > "bpp" needs to be signed for the error handling to work. > > Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> There's also "drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp result" from Andrzej Hajda from january the 14th doing the same change. Heiko > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 7bfe243..c35e5af 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi > *dsi) > > static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi) > { > - unsigned int bpp, i, pre; > + int bpp; > + unsigned int i, pre; > unsigned long mpclk, pllref, tmp; > unsigned int m = 1, n = 1, target_mbps = 1000; > unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) - 1].max_mbps;
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 7bfe243..c35e5af 100644 --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c @@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi *dsi) static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi) { - unsigned int bpp, i, pre; + int bpp; + unsigned int i, pre; unsigned long mpclk, pllref, tmp; unsigned int m = 1, n = 1, target_mbps = 1000; unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) - 1].max_mbps;
"bpp" needs to be signed for the error handling to work. Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>