diff mbox

[2/2] drm/exynos: mic: remove some dead code

Message ID 20160317103912.GB3100@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter March 17, 2016, 10:39 a.m. UTC
We know "ret" is zero and the test makes static checkers complain so
let's delete this printk.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Inki Dae March 25, 2016, 8:51 a.m. UTC | #1
Hi Dan,

2016? 03? 17? 19:39? Dan Carpenter ?(?) ? ?:
> We know "ret" is zero and the test makes static checkers complain so
> let's delete this printk.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index 890c9b1..12db353 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
>  		val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
>  
>  	regmap_write(mic->sysreg, DSD_CFG_MUX, val);
> -	if (ret)
> -		DRM_ERROR("mic: Failed to read system register\n");

I think we missed to keep return value from regmap_write function,
	ret = regmap_write(mic->sysreg, ....);
	if (ret)
		...

Thanks,
Inki Dae

>  }
>  
>  static int mic_sw_reset(struct exynos_mic *mic)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>
Dan Carpenter March 25, 2016, 8:09 p.m. UTC | #2
On Fri, Mar 25, 2016 at 05:51:20PM +0900, Inki Dae wrote:
> Hi Dan,
> 
> 2016? 03? 17? 19:39? Dan Carpenter ?(?) ? ?:
> > We know "ret" is zero and the test makes static checkers complain so
> > let's delete this printk.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > index 890c9b1..12db353 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
> >  		val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
> >  
> >  	regmap_write(mic->sysreg, DSD_CFG_MUX, val);
> > -	if (ret)
> > -		DRM_ERROR("mic: Failed to read system register\n");
> 
> I think we missed to keep return value from regmap_write function,
> 	ret = regmap_write(mic->sysreg, ....);
> 	if (ret)
> 		...

Yeah.  You're right.

regards,
dan carpenter
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index 890c9b1..12db353 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -130,8 +130,6 @@  static void mic_set_path(struct exynos_mic *mic, bool enable)
 		val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
 
 	regmap_write(mic->sysreg, DSD_CFG_MUX, val);
-	if (ret)
-		DRM_ERROR("mic: Failed to read system register\n");
 }
 
 static int mic_sw_reset(struct exynos_mic *mic)