Message ID | 20160402054224.GA19162@mwanda (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Sat, Apr 02, 2016 at 08:42:24AM +0300, Dan Carpenter wrote: > We accidentally return PTR_ERR(NULL) which is success instead of a > negative error code. > > Fixes: 879e40bea6f2 ('drm: ARM HDLCD - get rid of devm_clk_put()') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c > index 734849f..3ac1ae4 100644 > --- a/drivers/gpu/drm/arm/hdlcd_drv.c > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c > @@ -55,8 +55,9 @@ static int hdlcd_load(struct drm_device *drm, unsigned long flags) > hdlcd->mmio = devm_ioremap_resource(drm->dev, res); > if (IS_ERR(hdlcd->mmio)) { > DRM_ERROR("failed to map control registers area\n"); > + ret = PTR_ERR(hdlcd->mmio); > hdlcd->mmio = NULL; > - return PTR_ERR(hdlcd->mmio); > + return ret; Good catch, thanks for that! Acked-by: Liviu Dudau <Liviu.Dudau@arm.com> I've pulled your patch and sent an updated pull request. Best regards, Liviu > } > > version = hdlcd_read(hdlcd, HDLCD_REG_VERSION); > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index 734849f..3ac1ae4 100644 --- a/drivers/gpu/drm/arm/hdlcd_drv.c +++ b/drivers/gpu/drm/arm/hdlcd_drv.c @@ -55,8 +55,9 @@ static int hdlcd_load(struct drm_device *drm, unsigned long flags) hdlcd->mmio = devm_ioremap_resource(drm->dev, res); if (IS_ERR(hdlcd->mmio)) { DRM_ERROR("failed to map control registers area\n"); + ret = PTR_ERR(hdlcd->mmio); hdlcd->mmio = NULL; - return PTR_ERR(hdlcd->mmio); + return ret; } version = hdlcd_read(hdlcd, HDLCD_REG_VERSION);
We accidentally return PTR_ERR(NULL) which is success instead of a negative error code. Fixes: 879e40bea6f2 ('drm: ARM HDLCD - get rid of devm_clk_put()') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>