| Message ID | 20160413070742.GA9311@lkp-nex05 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 13/04/16 10:07, kbuild test robot wrote: > drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Karol Herbst <nouveau@karolherbst.de> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Martin Peres <martin.peres@free.fr>
> Martin Peres <martin.peres@free.fr> hat am 13. April 2016 um 09:55 > geschrieben: > > > On 13/04/16 10:07, kbuild test robot wrote: > > drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL > > check before freeing functions like kfree, debugfs_remove, > > debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider > > reorganizing relevant code to avoid passing NULL values. > > > > NULL check before some freeing functions is not needed. > > > > Based on checkpatch warning > > "kfree(NULL) is safe this check is probably not required" > > and kfreeaddr.cocci by Julia Lawall. > > > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > > > CC: Karol Herbst <nouveau@karolherbst.de> > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Martin Peres <martin.peres@free.fr> Signed-off-by: Karol Herbst <nouveau@karolherbst.de>
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c @@ -129,8 +129,7 @@ nvkm_iccsense_dtor(struct nvkm_subdev *s { struct nvkm_iccsense *iccsense = nvkm_iccsense(subdev); - if (iccsense->rails) - kfree(iccsense->rails); + kfree(iccsense->rails); return iccsense; }
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Karol Herbst <nouveau@karolherbst.de> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)