From patchwork Fri May 6 08:37:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 9030071 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 086B8BF29F for ; Fri, 6 May 2016 08:37:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 388612035D for ; Fri, 6 May 2016 08:37:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 59CF12034A for ; Fri, 6 May 2016 08:37:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B032D6EA4F; Fri, 6 May 2016 08:37:35 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id B82516EA4F for ; Fri, 6 May 2016 08:37:34 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from nuc-i3427.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 59270405-1500048 for multiple; Fri, 06 May 2016 09:37:36 +0100 Received: by nuc-i3427.alporthouse.com (sSMTP sendmail emulation); Fri, 06 May 2016 09:37:25 +0100 Date: Fri, 6 May 2016 09:37:25 +0100 From: Chris Wilson To: Daniel Vetter Subject: Re: [PATCH] drm/hisilicon: Use drm_connector_register_all Message-ID: <20160506083725.GD7026@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Daniel Vetter , DRI Development , Daniel Vetter References: <1462523321-11236-1-git-send-email-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1462523321-11236-1-git-send-email-daniel.vetter@ffwll.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Daniel Vetter , DRI Development X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, May 06, 2016 at 10:28:41AM +0200, Daniel Vetter wrote: > Also, the unbind function is totally not sufficient, and it's calling > the deprecated drm_put_dev. And you probably should markup all the others that are now deprecated and being phased out. Maybe behind drm_deprecated so that the spam is hidden behind another kconfig option rather than enabled-by-buildbots? -Chris diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 360b2a74e1ef..7efc0b477e38 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -1032,7 +1032,7 @@ extern void drm_vblank_post_modeset(struct drm_device *dev, unsigned int pipe); extern struct drm_master *drm_master_get(struct drm_master *master); extern void drm_master_put(struct drm_master **master); -extern void drm_put_dev(struct drm_device *dev); +__deprecated extern void drm_put_dev(struct drm_device *dev); extern void drm_unplug_dev(struct drm_device *dev); extern unsigned int drm_debug; extern bool drm_atomic;