From patchwork Wed May 18 10:23:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 9117731 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 84664BF29F for ; Wed, 18 May 2016 10:24:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B268A20320 for ; Wed, 18 May 2016 10:24:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id C95CA202F0 for ; Wed, 18 May 2016 10:24:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DFC496E046; Wed, 18 May 2016 10:24:02 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 839086E046 for ; Wed, 18 May 2016 10:24:01 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from nuc-i3427.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 59729326-1500048 for multiple; Wed, 18 May 2016 11:24:12 +0100 Received: by nuc-i3427.alporthouse.com (sSMTP sendmail emulation); Wed, 18 May 2016 11:23:57 +0100 Date: Wed, 18 May 2016 11:23:57 +0100 From: Chris Wilson To: Mark Brown Subject: Re: next-20160518 build: 2 failures 20 warnings (next-20160518) Message-ID: <20160518102357.GG30479@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Mark Brown , Daniel Vetter , Dave Airlie , Jie Qiu , CK Hu , kernel-build-reports@lists.linaro.org, linaro-kernel@lists.linaro.org, linux-next@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20160518101559.GJ8104@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160518101559.GJ8104@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: linaro-kernel@lists.linaro.org, Jie Qiu , kernel-build-reports@lists.linaro.org, Daniel Vetter , dri-devel@lists.freedesktop.org, linux-next@vger.kernel.org, Dave Airlie X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, May 18, 2016 at 11:15:59AM +0100, Mark Brown wrote: > On Wed, May 18, 2016 at 08:05:26AM +0100, Build bot for Mark Brown wrote: > > Today's -next fails to build arm and arm64 allmodconfigs fail to build > due to: > > > arm64-allmodconfig > > arm-allmodconfig > > ../drivers/gpu/drm/mediatek/mtk_drm_fb.c:141:30: error: passing argument 1 of 'drm_gem_object_lookup' from incompatible pointer type [-Werror=incompatible-pointer-types] > > ../drivers/gpu/drm/mediatek/mtk_drm_fb.c:141:8: error: too many arguments to function 'drm_gem_object_lookup' > > ../drivers/gpu/drm/mediatek/mtk_drm_gem.c:142:30: error: passing argument 1 of 'drm_gem_object_lookup' from incompatible pointer type [-Werror=incompatible-pointer-types] > > ../drivers/gpu/drm/mediatek/mtk_drm_gem.c:142:8: error: too many arguments to function 'drm_gem_object_lookup' > > Apparently triggered by 8ad0bd84f98607 (drm: Remove unused drm_device > from drm_gem_object_lookup()) which didn't update the Mediatek drivers. I'm pretty sure they didn't exist when I wrote the patch! -Chris diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.c b/drivers/gpu/drm/mediatek/mtk_drm_fb.c index 33d30c19f35f..147df85399ab 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_fb.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_fb.c @@ -138,7 +138,7 @@ struct drm_framebuffer *mtk_drm_mode_fb_create(struct drm_device *dev, if (drm_format_num_planes(cmd->pixel_format) != 1) return ERR_PTR(-EINVAL); - gem = drm_gem_object_lookup(dev, file, cmd->handles[0]); + gem = drm_gem_object_lookup(file, cmd->handles[0]); if (!gem) return ERR_PTR(-ENOENT); diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c index a773bfaea913..fa2ec0cd00e8 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c @@ -139,7 +139,7 @@ int mtk_drm_gem_dumb_map_offset(struct drm_file *file_priv, struct drm_gem_object *obj; int ret; - obj = drm_gem_object_lookup(dev, file_priv, handle); + obj = drm_gem_object_lookup(file_priv, handle); if (!obj) { DRM_ERROR("failed to lookup gem object.\n"); return -EINVAL;