From patchwork Mon Jul 25 10:09:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 9245525 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BB73C607FD for ; Mon, 25 Jul 2016 10:10:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9DF626223 for ; Mon, 25 Jul 2016 10:10:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9B6FD26E5D; Mon, 25 Jul 2016 10:10:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F61626223 for ; Mon, 25 Jul 2016 10:10:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CD056E362; Mon, 25 Jul 2016 10:10:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FE986E362 for ; Mon, 25 Jul 2016 10:10:26 +0000 (UTC) Received: by mail-wm0-x229.google.com with SMTP id q128so128509837wma.1 for ; Mon, 25 Jul 2016 03:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=sgJ+BoCLaYOMruafoeSfuzjNMlJ9NSatP8rsfPHVShY=; b=PWiX0oW0S9u5+TKAXDT5CDilokRUo3tT7VaIz6PB9aW5XygJGYPmuwFHn+N//liIQm IKDFSxnugpVcUzgB+gy19kR12edIgtqVXsEiY2SodWsO6JrqUk/ks8xuRpkqQ3TeMBOZ o5qQdNgwYgwQ9cR3kxswac1auEfTR8DHpmlms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=sgJ+BoCLaYOMruafoeSfuzjNMlJ9NSatP8rsfPHVShY=; b=kAgYwzRYbfW0gTaxGa+ngsQKixVlXrBjXDkidxfGW4SMcw2Y0aYjOHt+f6QH2vcsUM +yBWfFfA1K+Q11Y/pRAY3esvC7mrCzV2Mm00yowdXV25B1f8gmsN9JaZ0VLYX+HOGCri aYWx658rW2VYVgMx9Jy9mokdiRl9f0ONXHRcKhiuLegnBzDUF6Dbqv7nz7MPhL6Atmi5 5AW6x6LX/KV/4rQ2bGNycxuLZeNOUeALKSfT60oLQ06QLfvm2IyRd4TpQ3Z5Tk7BtGd1 fu48NIXZenC0A/XKJjHsqe7kSPZ5Osn3dJnk3RT84TTAM8yBYg3p3gXMI+b6GEipLw+j lBUg== X-Gm-Message-State: AEkoouvPyALFWGFytmDy1biRoGZhzDc1t7YyvJ4wg7U13AwJG8JFYhdWAifpuBPpq3orZ9Fh X-Received: by 10.194.149.133 with SMTP id ua5mr14203321wjb.79.1469441423648; Mon, 25 Jul 2016 03:10:23 -0700 (PDT) Received: from localhost.localdomain (host86-178-207-177.range86-178.btcentralplus.com. [86.178.207.177]) by smtp.gmail.com with ESMTPSA id a3sm14982242wjm.30.2016.07.25.03.10.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jul 2016 03:10:23 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] drm/sti: use new Reset API Date: Mon, 25 Jul 2016 11:09:33 +0100 Message-Id: <20160725100933.9261-1-lee.jones@linaro.org> X-Mailer: git-send-email 2.9.0 Cc: kernel@stlinux.com, Lee Jones , patrice.chotard@st.com, dri-devel@lists.freedesktop.org, vincent.abriou@st.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Since 0b52297f228 ("reset: Add support for shared reset controls") the new Reset API now demands consumers choose either an *_exclusive or a *_shared line when requesting reset lines. This issue was found when running a kernel containing the aforementioned patch which includes an informitive WARN(). It implies that one or more used reset lines are in fact shared. This is why we're using the *_shared variant. Signed-off-by: Lee Jones --- drivers/gpu/drm/sti/sti_compositor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_compositor.c b/drivers/gpu/drm/sti/sti_compositor.c index 3d2fa3a..c2ace02 100644 --- a/drivers/gpu/drm/sti/sti_compositor.c +++ b/drivers/gpu/drm/sti/sti_compositor.c @@ -234,12 +234,12 @@ static int sti_compositor_probe(struct platform_device *pdev) } /* Get reset resources */ - compo->rst_main = devm_reset_control_get(dev, "compo-main"); + compo->rst_main = devm_reset_control_get_shared(dev, "compo-main"); /* Take compo main out of reset */ if (!IS_ERR(compo->rst_main)) reset_control_deassert(compo->rst_main); - compo->rst_aux = devm_reset_control_get(dev, "compo-aux"); + compo->rst_aux = devm_reset_control_get_shared(dev, "compo-aux"); /* Take compo aux out of reset */ if (!IS_ERR(compo->rst_aux)) reset_control_deassert(compo->rst_aux);