From patchwork Tue Aug 30 06:55:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Liu X-Patchwork-Id: 9305009 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 17A5160756 for ; Tue, 30 Aug 2016 08:06:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0780428B0A for ; Tue, 30 Aug 2016 08:06:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F070B28B19; Tue, 30 Aug 2016 08:06:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A4ED828B0A for ; Tue, 30 Aug 2016 08:06:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC23B6E378; Tue, 30 Aug 2016 08:06:36 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 417806E357 for ; Tue, 30 Aug 2016 06:55:27 +0000 (UTC) Received: by mail-pf0-x241.google.com with SMTP id i6so693128pfe.0 for ; Mon, 29 Aug 2016 23:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=9lFP+2Z+h1RG+xemN3kO5vqU9WBKLtBRLnk8/6FhDCU=; b=E/kH5OwTRbPuqxOHcgD9+PL6ylILIOQ5Lf4NUc2hxkwHT4ydAoWOQWh13RhYRrtGxf vqb1VJlOF0u2Av7aNmrwmYgrpTyUsU8cbgwKI7sV9acuMv/dii4B0bc0MEcz5ldxMMuk PcLsXmgZXCHYfTe7tQfPaGUhcZm4FdP5lGc5Ti1GlBBJsp2OmLgqcIvE+lMfRW9XO8vU hwEychuGwCYkb0xNzG9K2o51NiYwNKsuGBwjGZegAz6eaHrP/Y6a1wJrC7MfReAufkCx 02hl/Mp8aIiyoYm/UnZIyNH2w5muGcv1C166aQug03lFBcI9/5H7I0lecfw9i4qTb3lx o1pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9lFP+2Z+h1RG+xemN3kO5vqU9WBKLtBRLnk8/6FhDCU=; b=EX0jN4PSgxRsCM3k5C3O8MZooTSQyQmIC0Rv9c5mDwcQiG7d6eNB/nS1ySY6SGQ2mw MhvaeAOmVegS6pYSTCeNiy1QXAeJmxx3dGaOxw04dlCYNwrLfsYSU0YoMYv5Zp+is/Oh uNxfviUzgukXuXYY3OyVxrxAyoYqnzyhEVrzX1UvmyyB31zEd+O7++lrWCbqvQZYbADh hnGWyo0HVHwDhuc3eUPN1wIW7EgTfyPM+lzfR8VrZcM0pKDrN8XL+AgPddhU0GnrymwU 3kGzy3JZRnHCOK/cxU+/NTR0WvuzWuhPKR6ZU0cjgpT2uifYv7L50hQkgjiGueLIrjEH EI0w== X-Gm-Message-State: AE9vXwNG8BmXDRUMcZaulQpjM/mgBhBifMBNsRvxlPsaJTvaIuepIVCUOhv8imexqcoN5Q== X-Received: by 10.98.65.81 with SMTP id o78mr3547272pfa.48.1472540126901; Mon, 29 Aug 2016 23:55:26 -0700 (PDT) Received: from 60-242-179-244.static.tpgi.com.au (60-242-179-244.static.tpgi.com.au. [60.242.179.244]) by smtp.gmail.com with ESMTPSA id yu7sm33038138pab.45.2016.08.29.23.55.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Aug 2016 23:55:26 -0700 (PDT) From: Jonathan Liu To: Maxime Ripard Subject: [PATCH] drm/sun4i: rgb: add missing calls to drm_panel_{prepare, unprepare} Date: Tue, 30 Aug 2016 16:55:00 +1000 Message-Id: <20160830065500.31847-1-net147@gmail.com> X-Mailer: git-send-email 2.9.3 X-Mailman-Approved-At: Tue, 30 Aug 2016 08:06:35 +0000 Cc: Jonathan Liu , linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP If the enable-gpios property of a simple panel in device tree is set, the GPIO is not toggled on/off because of missing calls to drm_panel_prepare and drm_panel_unprepare. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_rgb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c index f5bbac6..d6943e9 100644 --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c +++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c @@ -151,6 +151,7 @@ static void sun4i_rgb_encoder_enable(struct drm_encoder *encoder) DRM_DEBUG_DRIVER("Enabling RGB output\n"); + drm_panel_prepare(tcon->panel); drm_panel_enable(tcon->panel); sun4i_tcon_channel_enable(tcon, 0); } @@ -165,6 +166,7 @@ static void sun4i_rgb_encoder_disable(struct drm_encoder *encoder) sun4i_tcon_channel_disable(tcon, 0); drm_panel_disable(tcon->panel); + drm_panel_unprepare(tcon->panel); } static void sun4i_rgb_encoder_mode_set(struct drm_encoder *encoder,