From patchwork Fri Sep 30 16:20:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9358631 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F260E6075E for ; Fri, 30 Sep 2016 16:27:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E46BE2A04D for ; Fri, 30 Sep 2016 16:27:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D93AA2A0D3; Fri, 30 Sep 2016 16:27:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CD1202A04D for ; Fri, 30 Sep 2016 16:27:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A11F6EA97; Fri, 30 Sep 2016 16:27:06 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DB0B6E188 for ; Fri, 30 Sep 2016 16:27:01 +0000 (UTC) Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue103) with ESMTPA (Nemesis) id 0MCfv0-1bghAw2fli-009PIH; Fri, 30 Sep 2016 18:21:36 +0200 From: Arnd Bergmann To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= Subject: [PATCH] drm/amdgpu: enable powerplay unconditionally Date: Fri, 30 Sep 2016 18:20:56 +0200 Message-Id: <20160930162134.158641-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:+tX5ZwVqYu/bF58ydD2Ii+ypvsqBWK9IB+4lJG8TK5sJ6XC5fYW BL34Fm1gkjZW1UOah2xQea1JR/J//bpNHXClOntdCN5Owo4KLgxrPT28S0+cd81Bv2qzri1 7GDQMOmhvABscRiBvTPE3iLLY8qzcLDMdUFZ5hhayIQPiqwRup7huS2tusS2dfFm3nLtVa0 3a+qpw6//28bSsWaYqBww== X-UI-Out-Filterresults: notjunk:1; V01:K0:bYIYFam+aHs=:NNQbKm0rDwYAWQuhyLG3ot 8axHs/wVEAD/Q0S1Y6vHbE/gKtQFFyg1q2AiBlu6EQIexE/KcDSEoUpq1INVtzZcEpr8gVcUD uqSAu7TjByrXpDC2czVXjYUuv49wutaOeOxkqe33AwVLn3qgeW6w77iRwtUgQOM+L7sCviIJU j7IoJZX4H8QbMtLC/bIx6czu1aBh0ycoLiH0IgaqD4cGQ2O69voFoWYr5LAYWc5ihQnQdZdEY HlEu2O5jtGgXB6xJSJMBEwa+rjTTQ4WqlupV43h/d+yqM5GYdrLtW1MrMpSzJ6r4mQyMqsvnA /Ivc4ZGj23Iq4KD0Nn3M5MjTbQeyMYBTIn5JElffOc49eZLzeOgXcGZDaHcak7r8Q4bapNJML /LNMy5ZMwnfzoOl7dleH94ir/HxYCTl64SwMdJJoUdnLZ84ScI/0H8DoJBv80FmJY7DAJmrH1 qYSgFuq3Bx1f2zWlCN7+Cbqyj5t0ZrvVsvqEavQdxPpb1Xt+v3sM/bqsclmaTT8QQSVTsYurp bSEN8RjJinwkzjwnRPx7bClbn7Kanm6tLoPUxTLT0SH/PDhPOSXUxq0kztmqjBcpxnup5Otqd dBeCq1j6rnjFBG5dM/NjnP29dGPPYd/sZxy8CWzrxlIypVm0FUfRu+gP/5TX9IVZnj6oGwnHv vXfzDBKy2APoiJHCkXMmIfKQC6ByYge0l+rBpiKWi/OvvrEGbCFbaNyra4mr9J26eupM= Cc: Arnd Bergmann , Jammy Zhou , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rex Zhu X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Using the newly exported amd_set_clockgating_by_smu function in the main amdgpu driver means that we can no longer build the driver without also enabling the powerplay component, otherwise we get this link error: ERROR: "amd_set_clockgating_by_smu" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! The easiest way to avoid this error is to always enable the Kconfig symbol when the amdgpu driver is enabled. Fixes: a8ca34136453 ("drm/amdgpu: set gfx clock gating for tonga/polaris.") Fixes: 1bb08f91b0f6 ("drm/amdgpu: set system clock gating for tonga/polaris.") Signed-off-by: Arnd Bergmann --- It's quite likely that there is a better way to do this, as the separation of the drivers is intentional. If my patch isn't acceptable, please come up with a different solution. --- drivers/gpu/drm/amd/powerplay/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/Kconfig b/drivers/gpu/drm/amd/powerplay/Kconfig index af380335b425..6d4f155a0453 100644 --- a/drivers/gpu/drm/amd/powerplay/Kconfig +++ b/drivers/gpu/drm/amd/powerplay/Kconfig @@ -1,6 +1,4 @@ config DRM_AMD_POWERPLAY - bool "Enable AMD powerplay component" - depends on DRM_AMDGPU - default n + def_bool DRM_AMDGPU help select this option will enable AMD powerplay component.