| Message ID | 20161028090945.11573-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 28/10/16 10:09, Christophe JAILLET wrote: > 'devm_pinctrl_register()' returns an error pointer or a valid handle. So > checking for NULL here is pointless and can never trigger. > > Check the returned value with IS_ERR instead and propagate this value as > done in the other functions which call 'devm_pinctrl_register()' > > Fixes: 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support") > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/gpu/drm/tegra/dpaux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c > index 059f409556d5..2fde44c3a1b3 100644 > --- a/drivers/gpu/drm/tegra/dpaux.c > +++ b/drivers/gpu/drm/tegra/dpaux.c > @@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev) > dpaux->desc.owner = THIS_MODULE; > > dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux); > - if (!dpaux->pinctrl) { > + if (IS_ERR(dpaux->pinctrl)) { > dev_err(&pdev->dev, "failed to register pincontrol\n"); > - return -ENODEV; > + return PTR_ERR(dpaux->pinctrl); > } > #endif > /* enable and clear all interrupts */ Thanks for the fix! Acked-by: Jon Hunter <jonathanh@nvidia.com> Cheers Jon
On Fri, Oct 28, 2016 at 11:09:45AM +0200, Christophe JAILLET wrote: > 'devm_pinctrl_register()' returns an error pointer or a valid handle. So > checking for NULL here is pointless and can never trigger. > > Check the returned value with IS_ERR instead and propagate this value as > done in the other functions which call 'devm_pinctrl_register()' > > Fixes: 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support") > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/gpu/drm/tegra/dpaux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Thierry
diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 059f409556d5..2fde44c3a1b3 100644 --- a/drivers/gpu/drm/tegra/dpaux.c +++ b/drivers/gpu/drm/tegra/dpaux.c @@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev) dpaux->desc.owner = THIS_MODULE; dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux); - if (!dpaux->pinctrl) { + if (IS_ERR(dpaux->pinctrl)) { dev_err(&pdev->dev, "failed to register pincontrol\n"); - return -ENODEV; + return PTR_ERR(dpaux->pinctrl); } #endif /* enable and clear all interrupts */
'devm_pinctrl_register()' returns an error pointer or a valid handle. So checking for NULL here is pointless and can never trigger. Check the returned value with IS_ERR instead and propagate this value as done in the other functions which call 'devm_pinctrl_register()' Fixes: 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/gpu/drm/tegra/dpaux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)