diff mbox

drm/armada: Remove some dead code

Message ID 20161030153842.16745-1-christophe.jaillet@wanadoo.fr (mailing list archive)
State New, archived
Headers show

Commit Message

Christophe JAILLET Oct. 30, 2016, 3:38 p.m. UTC 
'dma_buf_map_attachment()' can not return NULL, so there is no need to
check for it.

Also add a space in order to improve layout.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpu/drm/armada/armada_gem.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Russell King (Oracle) Nov. 1, 2016, 8:14 p.m. UTC | #1 
On Sun, Oct 30, 2016 at 04:38:42PM +0100, Christophe JAILLET wrote:
> 'dma_buf_map_attachment()' can not return NULL, so there is no need to
> check for it.
> 
> Also add a space in order to improve layout.

Thanks, applied.
diff mbox

Patch

diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
index 806791897304..17a77f22b497 100644
--- a/drivers/gpu/drm/armada/armada_gem.c
+++ b/drivers/gpu/drm/armada/armada_gem.c
@@ -594,11 +594,7 @@  int armada_gem_map_import(struct armada_gem_object *dobj)
 	int ret;
 
 	dobj->sgt = dma_buf_map_attachment(dobj->obj.import_attach,
-					  DMA_TO_DEVICE);
-	if (!dobj->sgt) {
-		DRM_ERROR("dma_buf_map_attachment() returned NULL\n");
-		return -EINVAL;
-	}
+					   DMA_TO_DEVICE);
 	if (IS_ERR(dobj->sgt)) {
 		ret = PTR_ERR(dobj->sgt);
 		dobj->sgt = NULL;