From patchwork Fri Dec 9 14:19:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9468325 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1B96B60586 for ; Fri, 9 Dec 2016 14:20:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0E6FD28619 for ; Fri, 9 Dec 2016 14:20:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 037E42861F; Fri, 9 Dec 2016 14:20:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B70B028619 for ; Fri, 9 Dec 2016 14:20:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C7A936EA06; Fri, 9 Dec 2016 14:19:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A51A6E9F5 for ; Fri, 9 Dec 2016 14:19:43 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id g23so4318359wme.1 for ; Fri, 09 Dec 2016 06:19:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DM6MQTK1xtM1Wr9Bwl9xgOGPzYzGUOWJPfW6ay51EH8=; b=FgECegZgCrCuN0RxukJyLzjWUMIh474G4ZJD6AdjrAh0QAC6ZprLUSjqAWf+ZRSbsN 34KSMKQhoSm9q3EJMtSIc+nM5D1dbDKWqYenVzJ/xJ/W/1bfhnmLwKBJCTW+4jaOjsvP A65M2ha2QmrfbVICh151BnV5GySfC4p1USzs4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DM6MQTK1xtM1Wr9Bwl9xgOGPzYzGUOWJPfW6ay51EH8=; b=er0ffsp3d0YRq3vkdNtU3g632Hm549g6i0mF1DcEca0fpqSTyCGm2GlhHgvxUUIJad gYX+lAGkla1cJVcek6O43PbwJeFa9adzWLqciuGGGqASdzZYBWfNsDiHUYJha/U0zeSh 6jBjC1vxHgub+CM38NaATbW/+ckqZAOoWDZXmyZUZDsCiwqCmFSjBJn6oQgAsC1mfHSn J45Kc73k/M9k4NBszcaBDbP9ikwDRThB7IeKVPVZZFTm8fkee0Fz4R416bV9i9RXRVgu 1TQq0qMXdb8lucVthL0ri+Ck4GwzngACyXoBYMIZcz5FbvP7a5vPurMSiHpMeD19DgTm Rt1Q== X-Gm-Message-State: AKaTC03X448PYZgzlII1i4qwBu03YMI1q2Fv9n4l36gJCihM1nbIIzWYV0zJSlTHc2fHmQ== X-Received: by 10.28.146.201 with SMTP id u192mr7578123wmd.142.1481293181830; Fri, 09 Dec 2016 06:19:41 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:56b5:0:ac27:b86c:7764:9429]) by smtp.gmail.com with ESMTPSA id y4sm42573752wjp.0.2016.12.09.06.19.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Dec 2016 06:19:41 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 3/7] drm: setclientcap doesn't need the drm BKL Date: Fri, 9 Dec 2016 15:19:40 +0100 Message-Id: <20161209141944.22121-3-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20161209141944.22121-1-daniel.vetter@ffwll.ch> References: <20161209141944.22121-1-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP It only updates per-file feature flags. And all the ioctl which change behaviour depending upon these flags (they're all kms features) do _not_ hold the BKL. Therefor this is pure cargo-cult and can be removed. Note that there's a risk that the ioctl will behave inconsistently, but that's ok. The only thing it's not allowed to do is oops the kernel, and from an audit all places are safe. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 42a17ea5d801..e1b2c372f021 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -541,7 +541,7 @@ static const struct drm_ioctl_desc drm_ioctls[] = { DRM_IOCTL_DEF(DRM_IOCTL_GET_CLIENT, drm_getclient, DRM_UNLOCKED), DRM_IOCTL_DEF(DRM_IOCTL_GET_STATS, drm_getstats, DRM_UNLOCKED), DRM_IOCTL_DEF(DRM_IOCTL_GET_CAP, drm_getcap, DRM_UNLOCKED|DRM_RENDER_ALLOW), - DRM_IOCTL_DEF(DRM_IOCTL_SET_CLIENT_CAP, drm_setclientcap, 0), + DRM_IOCTL_DEF(DRM_IOCTL_SET_CLIENT_CAP, drm_setclientcap, DRM_UNLOCKED), DRM_IOCTL_DEF(DRM_IOCTL_SET_VERSION, drm_setversion, DRM_UNLOCKED | DRM_MASTER), DRM_IOCTL_DEF(DRM_IOCTL_SET_UNIQUE, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),