From patchwork Fri Dec 9 18:53:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9468939 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DFE93602F0 for ; Fri, 9 Dec 2016 18:53:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D3BBC2866B for ; Fri, 9 Dec 2016 18:53:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C85BF28670; Fri, 9 Dec 2016 18:53:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 705D32866B for ; Fri, 9 Dec 2016 18:53:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B65EB6EA7E; Fri, 9 Dec 2016 18:53:26 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wj0-x243.google.com (mail-wj0-x243.google.com [IPv6:2a00:1450:400c:c01::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 694EF6EA65 for ; Fri, 9 Dec 2016 18:53:09 +0000 (UTC) Received: by mail-wj0-x243.google.com with SMTP id he10so3570589wjc.2 for ; Fri, 09 Dec 2016 10:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xF5BMF8iAfq9f5iwXpXwQ0H5Vy3Nnh213D6p+mftad0=; b=ld/TmC1Za/U0/iSvQsTEovVjNsex8NpUP8wWMSJFOeNdiWgpu1yMoIdzQ01Qgg0fSy NcmQrRNydEHwqWLfg1mpq8MEwQpXpsLzc+Rt56bM3Iwy708fP2smVt0OUQG3PNgiqBWt xNzIuAXepbxLCchpCYJLwHWQuYpssn2JPofDQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xF5BMF8iAfq9f5iwXpXwQ0H5Vy3Nnh213D6p+mftad0=; b=etYn8qHgbWg9glVvq8QBqM9Kwm1jug8DjTlFbagL9Cj7NdzWFSvhsvSPq6nWAPgMSQ YPFo/ulaIQxP533QwsvthdFix7oJqpgXbkavPUMP9T8mdovK00Y4KEww1yXnBUNHz+x9 CNSf106MFFboyOJw/g5VT/nHxOH890HXvPNrH6dRbQ1xYTxeM1n5/TfOxDI8gjdSxawX /HP5aZXMjy/eY292cvQCP5WX9d/VktZRmrEyTvEXhh4GuzDQAAsXwzWMkpkjONT+QnpN IVapiIoBnaG0yYfunzzYHvFhSwhRxXOpsxKKuXYjxTehfVvyEa+towesyLVJ7Rb6eVbA 3DUg== X-Gm-Message-State: AKaTC01+jApW4Vchar66eEHa/2K1hpElgtu10xPm5hSnYfiQBEDkZmAQKhJK94aYEC5oqg== X-Received: by 10.194.205.225 with SMTP id lj1mr79551197wjc.122.1481309587585; Fri, 09 Dec 2016 10:53:07 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:56b5:0:ac27:b86c:7764:9429]) by smtp.gmail.com with ESMTPSA id p144sm21960991wme.23.2016.12.09.10.53.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Dec 2016 10:53:07 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 2/5] dma-buf: Update kerneldoc for sync_file_create Date: Fri, 9 Dec 2016 19:53:06 +0100 Message-Id: <20161209185309.1682-3-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20161209185309.1682-1-daniel.vetter@ffwll.ch> References: <20161209185309.1682-1-daniel.vetter@ffwll.ch> Cc: Jonathan Corbet , Daniel Vetter , Intel Graphics Development , linux-doc@vger.kernel.org, Daniel Vetter , Gustavo Padovan X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP This was missed when adding a dma_fence_get call. While at it also remove the kerneldoc for the static inline helper - no point documenting internals down to every detail. Fixes: 30cd85dd6edc ("dma-buf/sync_file: hold reference to fence when creating sync_file") Cc: Gustavo Padovan Cc: Sean Paul Cc: linux-doc@vger.kernel.org Cc: Jonathan Corbet Cc: Sumit Semwal Signed-off-by: Daniel Vetter Reviewed-by: Gustavo Padovan --- drivers/dma-buf/sync_file.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c index 6d802f2d2881..d5179d7e8575 100644 --- a/drivers/dma-buf/sync_file.c +++ b/drivers/dma-buf/sync_file.c @@ -67,9 +67,10 @@ static void fence_check_cb_func(struct dma_fence *f, struct dma_fence_cb *cb) * sync_file_create() - creates a sync file * @fence: fence to add to the sync_fence * - * Creates a sync_file containg @fence. Once this is called, the sync_file - * takes ownership of @fence. The sync_file can be released with - * fput(sync_file->file). Returns the sync_file or NULL in case of error. + * Creates a sync_file containg @fence. This function acquires and additional + * reference of @fence for the newly-created &sync_file, if it succeeds. The + * sync_file can be released with fput(sync_file->file). Returns the + * sync_file or NULL in case of error. */ struct sync_file *sync_file_create(struct dma_fence *fence) { @@ -90,13 +91,6 @@ struct sync_file *sync_file_create(struct dma_fence *fence) } EXPORT_SYMBOL(sync_file_create); -/** - * sync_file_fdget() - get a sync_file from an fd - * @fd: fd referencing a fence - * - * Ensures @fd references a valid sync_file, increments the refcount of the - * backing file. Returns the sync_file or NULL in case of error. - */ static struct sync_file *sync_file_fdget(int fd) { struct file *file = fget(fd);