| Message ID | 20161228143216.26821-3-krisman@collabora.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Inki, On 28.12.2016 15:32, Gabriel Krisman Bertazi wrote: > num_ioctls is already assigned when declaring the exynos_drm_driver > structure. No need to duplicate it here. > > Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> It looks like the patch has not been merged, probably due to lack of your e-mail. Anyway it does the right thing, could you take it? Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> -- Regards Andrzej > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c > index 739180ac3da5..44b4d07eefb5 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c > @@ -570,7 +570,6 @@ static int exynos_drm_platform_probe(struct platform_device *pdev) > struct component_match *match; > > pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); > - exynos_drm_driver.num_ioctls = ARRAY_SIZE(exynos_ioctls); > > match = exynos_drm_match_add(&pdev->dev); > if (IS_ERR(match))
Hi Andrzej, 2017년 06월 19일 20:03에 Andrzej Hajda 이(가) 쓴 글: > Hi Inki, > > On 28.12.2016 15:32, Gabriel Krisman Bertazi wrote: >> num_ioctls is already assigned when declaring the exynos_drm_driver >> structure. No need to duplicate it here. >> >> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> > > It looks like the patch has not been merged, probably due to lack of > your e-mail. > Anyway it does the right thing, could you take it? Got it. Thanks for notice. Thanks, Inki Dae > > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > > -- > Regards > Andrzej > >> --- >> drivers/gpu/drm/exynos/exynos_drm_drv.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c >> index 739180ac3da5..44b4d07eefb5 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c >> @@ -570,7 +570,6 @@ static int exynos_drm_platform_probe(struct platform_device *pdev) >> struct component_match *match; >> >> pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); >> - exynos_drm_driver.num_ioctls = ARRAY_SIZE(exynos_ioctls); >> >> match = exynos_drm_match_add(&pdev->dev); >> if (IS_ERR(match)) > > > >
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 739180ac3da5..44b4d07eefb5 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -570,7 +570,6 @@ static int exynos_drm_platform_probe(struct platform_device *pdev) struct component_match *match; pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); - exynos_drm_driver.num_ioctls = ARRAY_SIZE(exynos_ioctls); match = exynos_drm_match_add(&pdev->dev); if (IS_ERR(match))
num_ioctls is already assigned when declaring the exynos_drm_driver structure. No need to duplicate it here. Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 1 - 1 file changed, 1 deletion(-)