diff mbox

[-next] drm/atomic: make release_crtc_commit() static

Message ID 20170112142157.14684-1-weiyj.lk@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Yongjun Jan. 12, 2017, 2:21 p.m. UTC 
From: Wei Yongjun <weiyongjun1@huawei.com>

Fixes the following sparse warning:

drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning:
 symbol 'release_crtc_commit' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/drm_atomic_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gustavo Padovan Jan. 16, 2017, 9:36 p.m. UTC | #1 
Hi Wei,

2017-01-12 Wei Yongjun <weiyj.lk@gmail.com>:

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fixes the following sparse warning:
> 
> drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning:
>  symbol 'release_crtc_commit' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/gpu/drm/drm_atomic_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Gustavo
Daniel Vetter Jan. 23, 2017, 8:01 a.m. UTC | #2 
On Mon, Jan 16, 2017 at 07:36:27PM -0200, Gustavo Padovan wrote:
> Hi Wei,
> 
> 2017-01-12 Wei Yongjun <weiyj.lk@gmail.com>:
> 
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> > 
> > Fixes the following sparse warning:
> > 
> > drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning:
> >  symbol 'release_crtc_commit' was not declared. Should it be static?
> > 
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
> >  drivers/gpu/drm/drm_atomic_helper.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Thanks for the patch, applied to drm-misc.

Gustavo, for next time around please just use your commit rights when
reviewing a simple patch like this :-)
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 7b71ac4..e2e5a74 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -1357,7 +1357,7 @@  static int stall_checks(struct drm_crtc *crtc, bool nonblock)
 	return ret < 0 ? ret : 0;
 }
 
-void release_crtc_commit(struct completion *completion)
+static void release_crtc_commit(struct completion *completion)
 {
 	struct drm_crtc_commit *commit = container_of(completion,
 						      typeof(*commit),