| Message ID | 20170203202342.13128-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Feb 3, 2017 at 3:23 PM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > bo_va is being kfree'd twice, once in the call to amdgpu_vm_bo_rmv > and then a short while later. Fix this double free by removing > the 2nd kfree. > > Detected by CoverityScan, CID#1399524 ("Double Free") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied. thanks! > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > index 3fd951c..dcfb7df 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > @@ -83,7 +83,6 @@ int amdgpu_map_static_csa(struct amdgpu_device *adev, struct amdgpu_vm *vm) > DRM_ERROR("failed to do bo_map on static CSA, err=%d\n", r); > amdgpu_vm_bo_rmv(adev, bo_va); > ttm_eu_backoff_reservation(&ticket, &list); > - kfree(bo_va); > return r; > } > > -- > 2.10.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c index 3fd951c..dcfb7df 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c @@ -83,7 +83,6 @@ int amdgpu_map_static_csa(struct amdgpu_device *adev, struct amdgpu_vm *vm) DRM_ERROR("failed to do bo_map on static CSA, err=%d\n", r); amdgpu_vm_bo_rmv(adev, bo_va); ttm_eu_backoff_reservation(&ticket, &list); - kfree(bo_va); return r; }