From patchwork Fri Feb 10 19:59:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 9567409 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 57BE3601C3 for ; Fri, 10 Feb 2017 19:59:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E00B26E4D for ; Fri, 10 Feb 2017 19:59:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F31B285C8; Fri, 10 Feb 2017 19:59:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B130A26E4D for ; Fri, 10 Feb 2017 19:59:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 980FF6ED69; Fri, 10 Feb 2017 19:59:17 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0651C6ED69; Fri, 10 Feb 2017 19:59:17 +0000 (UTC) Received: by mail-wr0-x244.google.com with SMTP id o16so16211876wra.2; Fri, 10 Feb 2017 11:59:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=llqLXxy3WqGzJ14dGc+I3t3HKmUcnlAHW/mXqMAR9ZQ=; b=Oq/lI78sb4XPYFalB1z2NYq0mm17jpi05Sd41KOpYJXygIwYPKocWukpPzvuf5oZlk ND7OT5CillcOxKbNTIO/62hGqqU+azIY+k1Nq0i2fwwhaKhcRkTs0gG9T96lfk/3R7F4 V7TlWRMs7SmlO1t6Ezez2MbEMfnPuS9NXo9VYOdiMOuvCSlGRYBxzNbBAF2rKgCLkYp0 UKYPXgTHeMIj12YEQWL2sFNws0qXrOUJRqTCJEOiG5shz+GV4yzMzSVoBmVthktH1Em4 mRXOndnDQ1FkZZL48QH+hI755DwzzR+B9FkkTngJ/V2q7te4M2idI8MYXnUF/TZQdBpL SAjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=llqLXxy3WqGzJ14dGc+I3t3HKmUcnlAHW/mXqMAR9ZQ=; b=gI+OpaTHOjFF7XWL46xLp9d0DLRWlCz1xmnn6GEz8vkyZPzH9Gtni6sVVpGWiMaelZ uY+kWxihLGzE8MUc0+AN5pfPok862j0laHYvozIVt+ohWZE/3tIQXfUcYACcbmxAWHof A5GKN7PGw899RFU/XYh0nt4RmIUuPPrNp8VoRHIL0rk3bYDI59RpRBbWiDILTkVJVhFb ohGGiAYzSGkaINUJR//UyknMFNNSLg5NSlHV25Q7t40uqY5Fezc1A4TtFAQhaupYrWdq 5omLHRb/6PwGdkmhQEYn6gu2XpeoMA3X/2g/Gp4ahQ023k/4xLXNuvDhqQURCaS7mvLv sANA== X-Gm-Message-State: AMke39nodajIovpAtAK8BcUZPM7xrGhh8aHPrgaEYFXNNDOOm2sWX6Mqw1bnqRd4ogNpfQ== X-Received: by 10.223.134.218 with SMTP id 26mr9081732wry.104.1486756755723; Fri, 10 Feb 2017 11:59:15 -0800 (PST) Received: from haswell.alporthouse.com ([78.156.65.138]) by smtp.gmail.com with ESMTPSA id m188sm1096475wma.27.2017.02.10.11.59.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Feb 2017 11:59:15 -0800 (PST) From: Chris Wilson To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm: Reduce EDID warnings from DRM_ERROR to DRM_NOTE Date: Fri, 10 Feb 2017 19:59:13 +0000 Message-Id: <20170210195913.9878-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.11.0 Cc: intel-gfx@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The warnings from parsing the EDID are not driver errors, but the "normal but significant" conditions from the external device. As such, they do not need the ferocity of an *ERROR*, but can use the less harsh DRM_NOTE instead. Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_edid.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 5a3b34a88ac3..24e7b282f16c 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -1140,7 +1140,7 @@ bool drm_edid_block_valid(u8 *raw_edid, int block, bool print_bad_edid, DRM_DEBUG("Assuming a KVM switch modified the CEA block but left the original checksum\n"); } else { if (print_bad_edid) - DRM_ERROR("EDID checksum is invalid, remainder is %d\n", csum); + DRM_NOTE("EDID checksum is invalid, remainder is %d\n", csum); goto bad; } @@ -1150,7 +1150,7 @@ bool drm_edid_block_valid(u8 *raw_edid, int block, bool print_bad_edid, switch (raw_edid[0]) { case 0: /* base */ if (edid->version != 1) { - DRM_ERROR("EDID has major version %d, instead of 1\n", edid->version); + DRM_NOTE("EDID has major version %d, instead of 1\n", edid->version); goto bad; } @@ -1167,11 +1167,12 @@ bool drm_edid_block_valid(u8 *raw_edid, int block, bool print_bad_edid, bad: if (print_bad_edid) { if (drm_edid_is_zero(raw_edid, EDID_LENGTH)) { - printk(KERN_ERR "EDID block is all zeroes\n"); + printk(KERN_NOTICE "EDID block is all zeroes\n"); } else { - printk(KERN_ERR "Raw EDID:\n"); - print_hex_dump(KERN_ERR, " \t", DUMP_PREFIX_NONE, 16, 1, - raw_edid, EDID_LENGTH, false); + printk(KERN_NOTICE "Raw EDID:\n"); + print_hex_dump(KERN_NOTICE, + " \t", DUMP_PREFIX_NONE, 16, 1, + raw_edid, EDID_LENGTH, false); } } return false; @@ -4002,7 +4003,7 @@ static int validate_displayid(u8 *displayid, int length, int idx) csum += displayid[i]; } if (csum) { - DRM_ERROR("DisplayID checksum invalid, remainder is %d\n", csum); + DRM_NOTE("DisplayID checksum invalid, remainder is %d\n", csum); return -EINVAL; } return 0;