From patchwork Tue Feb 14 21:31:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9572957 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DE222601E7 for ; Tue, 14 Feb 2017 21:32:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CEFD126E4C for ; Tue, 14 Feb 2017 21:32:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C39BB27813; Tue, 14 Feb 2017 21:32:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7CBA826E4C for ; Tue, 14 Feb 2017 21:32:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 382576E1C8; Tue, 14 Feb 2017 21:32:45 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by gabe.freedesktop.org (Postfix) with ESMTPS id F422A6E1C8 for ; Tue, 14 Feb 2017 21:32:42 +0000 (UTC) Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue004 [212.227.15.129]) with ESMTPA (Nemesis) id 0MBo5j-1cVBaN43kN-00AoG6; Tue, 14 Feb 2017 22:32:21 +0100 From: Arnd Bergmann To: Mark Yao , David Airlie Subject: [PATCH] drm/rockchip: add extcon dependency for DP Date: Tue, 14 Feb 2017 22:31:51 +0100 Message-Id: <20170214213215.2888509-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:98OU8Ek/k/w2OXvMe6Wtei8vmP7NfNqOoBOHszSvW+ve6Odp0NV CMI56pSoohvShQr1CTBsE83uI7rZtEKhauCMv2peJ0LuBTnHxLHCDIZsA8E6PadYYLxdpMB 6bG8jQekv0ZwBvy1ScZa1lwunOptui0lPAtSx4j/zmMsHBeTfaVC1O07itbQoqnJ4aT9veL zAaT6U+gv2kLxMLYHNUEQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:nXeP+yRGcSQ=:tFJWjUwooUFQTN+WUexEYl Vedrl/yYE3t/h3mSScdtFZaFN3CHspx4wooJtQ9k7D3VO0IGj1z9McE0lWFqAokciYUdzvZjO jzeV2qor0G9rvP8lQ9myuv4+HkoGedS8gzgNQzrJKPUylRwUouETs0fAucxtZF6dva1XVDpCL 6JB5G0oVmlgbrXdK7lo9NZU+HKTFDntwZrbRl67k2yOJCZnBXWcrK/TntdC+8oO53xQFItaZ5 72F4VHSynse/ByjLz7Mc25sQxGaQFg/C2FNAO5tmchjEEeXgsWVbIfkTIbcLCozyswWrp0pRt hY3tTSPBgHQmXSRL/RB9NBR0it/PjdIoVM1CVCKMvUrJOmU9j0VMuCQ9Hmw+auZ7HnwzWXZps tZDf2TGyMaign9kG+YpjT2KYGU7k1lKP2hhty+fjJKGVSU7O8rKYfm1Ifw7EWtH8cEjxp7sNs Af0Snmx5dP5EZvZSQFr7vz6YJDznX7sgwPzl8nvSFjK8qd0njlsNg9BUjZ99rUYDUFH5uQkBr PPlOoY5lZUbET4/BPgijPZTtkqNhlRB18gjBKxvBiFNVWK0zerI8+nwWN/oLJKrWRhiB/4qXo Jap9eMxgSihW2irQOqLg3VmHHS8U+IMqe/kO/sOiWY1Obouf2k0QbpYWxkzyVpCM4Fa0Ddj+F mIb1iQCRu9ZTnnZT9XnGFqRS2Lct0Qw4akp1vVXiprdZueo1Di3yXqUSvJVzHI472+xA= Cc: Arnd Bergmann , Tobias Jakobi , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Zhong , Yakir Yang , Guenter Roeck , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The newly added DP driver links against the extcon core, which fails when extcon is a module and this driver is not: drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state' cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property' Let's make Kconfig enforce correct behavior with a dependency. Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Signed-off-by: Arnd Bergmann Reviewed-by: Guenter Roeck --- drivers/gpu/drm/rockchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig index ad31b3eb408f..0e4eb845cbb0 100644 --- a/drivers/gpu/drm/rockchip/Kconfig +++ b/drivers/gpu/drm/rockchip/Kconfig @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP config ROCKCHIP_CDN_DP tristate "Rockchip cdn DP" depends on DRM_ROCKCHIP + depends on EXTCON select SND_SOC_HDMI_CODEC if SND_SOC help This selects support for Rockchip SoC specific extensions