| Message ID | 20170216154207.17763-1-p.zabel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/16/2017 07:42 AM, Philipp Zabel wrote: > Setting dev->of_node changes the modalias and breaks module autoloading. > Since there is an of_node field in the platform data passed to child > devices, we don't even need this anymore. > > Suggested-by: Russell King <linux@armlinux.org.uk> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > --- > drivers/gpu/ipu-v3/ipu-common.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c > index 97218af4fe75c..8368e6f766ee5 100644 > --- a/drivers/gpu/ipu-v3/ipu-common.c > +++ b/drivers/gpu/ipu-v3/ipu-common.c > @@ -1238,12 +1238,6 @@ static int ipu_add_client_devices(struct ipu_soc *ipu, unsigned long ipu_base) > platform_device_put(pdev); > goto err_register; > } > - > - /* > - * Set of_node only after calling platform_device_add. Otherwise > - * the platform:imx-ipuv3-crtc modalias won't be used. > - */ > - pdev->dev.of_node = of_node; > } > > return 0; > Acked-by: Steve Longerbeam <steve_longerbeam@mentor.com>
diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c index 97218af4fe75c..8368e6f766ee5 100644 --- a/drivers/gpu/ipu-v3/ipu-common.c +++ b/drivers/gpu/ipu-v3/ipu-common.c @@ -1238,12 +1238,6 @@ static int ipu_add_client_devices(struct ipu_soc *ipu, unsigned long ipu_base) platform_device_put(pdev); goto err_register; } - - /* - * Set of_node only after calling platform_device_add. Otherwise - * the platform:imx-ipuv3-crtc modalias won't be used. - */ - pdev->dev.of_node = of_node; } return 0;
Setting dev->of_node changes the modalias and breaks module autoloading. Since there is an of_node field in the platform data passed to child devices, we don't even need this anymore. Suggested-by: Russell King <linux@armlinux.org.uk> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> --- drivers/gpu/ipu-v3/ipu-common.c | 6 ------ 1 file changed, 6 deletions(-)