| Message ID | 20170223103956.GA27484@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On to, 2017-02-23 at 13:39 +0300, Dan Carpenter wrote: > This function is a bool type where we are supposed to return false on > failure and true on success. Negative error codes are currently treated > as true. > > Fixes: a1b2278e4dfc ("drm/i915: skylake panel fitting using shared scalers") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> <SNIP> > > @@ -1637,10 +1637,8 @@ intel_dp_compute_config(struct intel_encoder *encoder, > adjusted_mode); > > if (INTEL_GEN(dev_priv) >= 9) { > - int ret; > - ret = skl_update_scaler_crtc(pipe_config); > - if (ret) > - return ret; > + if (skl_update_scaler_crtc(pipe_config)) > + return false; > } You can drop the braces, too. Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Regards, Joonas
On Thu, Feb 23, 2017 at 01:09:14PM +0200, Joonas Lahtinen wrote: > On to, 2017-02-23 at 13:39 +0300, Dan Carpenter wrote: > > This function is a bool type where we are supposed to return false on > > failure and true on success. Negative error codes are currently treated > > as true. > > > > Fixes: a1b2278e4dfc ("drm/i915: skylake panel fitting using shared scalers") > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > <SNIP> > > > > > @@ -1637,10 +1637,8 @@ intel_dp_compute_config(struct intel_encoder *encoder, > > adjusted_mode); > > > > if (INTEL_GEN(dev_priv) >= 9) { > > - int ret; > > - ret = skl_update_scaler_crtc(pipe_config); > > - if (ret) > > - return ret; > > + if (skl_update_scaler_crtc(pipe_config)) > > + return false; > > } > > You can drop the braces, too. > Multi-line indents get braces for readability. regards, dan carpenter
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index d1670b8afbf5..9173548ba601 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -1637,10 +1637,8 @@ intel_dp_compute_config(struct intel_encoder *encoder, adjusted_mode); if (INTEL_GEN(dev_priv) >= 9) { - int ret; - ret = skl_update_scaler_crtc(pipe_config); - if (ret) - return ret; + if (skl_update_scaler_crtc(pipe_config)) + return false; } if (HAS_GMCH_DISPLAY(dev_priv))
This function is a bool type where we are supposed to return false on failure and true on success. Negative error codes are currently treated as true. Fixes: a1b2278e4dfc ("drm/i915: skylake panel fitting using shared scalers") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>