From patchwork Tue Feb 28 09:46:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9595029 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5C9B060453 for ; Tue, 28 Feb 2017 09:46:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5201A28518 for ; Tue, 28 Feb 2017 09:46:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 46AFC2851F; Tue, 28 Feb 2017 09:46:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C96D528518 for ; Tue, 28 Feb 2017 09:46:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 47DD06E0C4; Tue, 28 Feb 2017 09:46:49 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3431F6E0C4 for ; Tue, 28 Feb 2017 09:46:48 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id r18so1414023wmd.3 for ; Tue, 28 Feb 2017 01:46:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=gt11RiwvAAKi8s/ROY7MkVkRJKDIoHCvO7B0wnIHga8=; b=AEITusUYbxgoQqhP49LQEgMcBdykn/mEr06ftfskkRK8D5bzVe7G6kG6JqpanCYo3/ WHsCcolmhispPIDTTpjhFBPhtVmh/ZzUOl3QpwaQLH6ViqiTY+FOH75Z4r3D2VbGZ9ce MsShgy/TnMaHnzZ2+U+o9jLcqebxZTK2R7IRU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gt11RiwvAAKi8s/ROY7MkVkRJKDIoHCvO7B0wnIHga8=; b=jQzbmba0AC51vHgvTW79fZ0v10auTOtCR9zgW40nJinRxGJ0GrDwuXkStb7wd6bq3E OFcIB4rkojfmrt9yuHV4oME6U2UuA4tSr8qtTrtVMO3yY+iOUYwJmc+XzxEOqfkM5Wtx lP+BTsLixzR47P6kUebK7JEyi601GoX8xtjbiEXTtBTvndIEs2OenbyUKZ6eUwlbodx4 jkO5ZjpZVESJLmVCH/E4DxpZGV0BUK/BrMJAdeGfwAQKhs8WJ0QgmH4AvliFCqFft1Qx PG7ys/F4v3clnhS6bCSnLnmdjEY1rQQKpAwnI5rFPO7drktXAW+cFUK90XL6ty/UkhVM jotQ== X-Gm-Message-State: AMke39kRtQzaUhJ18BlVsDu9j6GtWyN0E0JGCfo2nGSLWfIUOXcqQw0PNOm+zeQ2FG5DhA== X-Received: by 10.28.45.213 with SMTP id t204mr17446242wmt.113.1488275206424; Tue, 28 Feb 2017 01:46:46 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:56c9:0:decc:6e78:7e96:b452]) by smtp.gmail.com with ESMTPSA id l41sm1549566wre.23.2017.02.28.01.46.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Feb 2017 01:46:45 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH] drm-misc: Document review best practices Date: Tue, 28 Feb 2017 10:46:40 +0100 Message-Id: <20170228094640.32581-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.11.0 Cc: Daniel Vetter , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Let's make sure that review doesn't go through needless cycles. Diff doesn't show this, but this is only for the "small drivers" part of drm. Acked-by: Boris Brezillon Acked-by: Jani Nikula Signed-off-by: Daniel Vetter Acked-by: Eric Anholt --- drm-misc.rst | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drm-misc.rst b/drm-misc.rst index 73882dc55be6..d6367686d561 100644 --- a/drm-misc.rst +++ b/drm-misc.rst @@ -72,7 +72,7 @@ Merge Criteria Right now the only hard merge criteria are: -* Patch is properly reviewed or at least ack, i.e. don't just push your own +* Patch is properly reviewed or at least Ack, i.e. don't just push your own stuff directly. * drm-misc is for drm core (non-driver) patches, subsystem-wide refactorings, @@ -132,6 +132,16 @@ Slightly different rules apply: most cases this will just along the lines of "Looks good, Ack". drm-misc maintainers will help out with getting that review market going. +* Best practice for review: When you have some suggestions and comments for + future work, please make sure you don't forget your Ack tag to unblock the + original patch. And if you think something really must be fixed before + merging, please give a conditional Ack along the lines of "Fix + $specific_thing, with that addressed, Ack". The goal is to always have a clear + and reasonable speedy path towards getting the patch merged. For authors on + the other side, just do the minimal rework and push the patch, and do any + more involved rework in follow-up work. This way lenghty review cycles get + avoided, which are a drag for both reviewer and author. + Tooling =======