| Message ID | 20170228141837.22949-4-p.zabel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Dienstag, den 28.02.2017, 15:18 +0100 schrieb Philipp Zabel: > drm_atomic_helper_cleanup_planes only calls the cleanup_fb plane > helpers, which we don't implement as a CMA framebuffer based driver. > There is no reason to wait for vblanks in commit_tail only to do nothing > afterwards. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > Changes since v2: > - New patch that removes wait_for_vblanks and cleanup_planes instead > of reordering commit_hw_done and wait_for_vblanks. > --- > drivers/gpu/drm/imx/imx-drm-core.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > index f562cb7964b08..0a5e4fbb906bf 100644 > --- a/drivers/gpu/drm/imx/imx-drm-core.c > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > @@ -170,10 +170,6 @@ static void imx_drm_atomic_commit_tail(struct drm_atomic_state *state) > drm_atomic_helper_commit_modeset_enables(dev, state); > > drm_atomic_helper_commit_hw_done(state); > - > - drm_atomic_helper_wait_for_vblanks(dev, state); > - > - drm_atomic_helper_cleanup_planes(dev, state); > } > > static struct drm_mode_config_helper_funcs imx_drm_mode_config_helpers = {
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index f562cb7964b08..0a5e4fbb906bf 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -170,10 +170,6 @@ static void imx_drm_atomic_commit_tail(struct drm_atomic_state *state) drm_atomic_helper_commit_modeset_enables(dev, state); drm_atomic_helper_commit_hw_done(state); - - drm_atomic_helper_wait_for_vblanks(dev, state); - - drm_atomic_helper_cleanup_planes(dev, state); } static struct drm_mode_config_helper_funcs imx_drm_mode_config_helpers = {
drm_atomic_helper_cleanup_planes only calls the cleanup_fb plane helpers, which we don't implement as a CMA framebuffer based driver. There is no reason to wait for vblanks in commit_tail only to do nothing afterwards. Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> --- Changes since v2: - New patch that removes wait_for_vblanks and cleanup_planes instead of reordering commit_hw_done and wait_for_vblanks. --- drivers/gpu/drm/imx/imx-drm-core.c | 4 ---- 1 file changed, 4 deletions(-)