From patchwork Fri Mar 3 11:39:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Keeping X-Patchwork-Id: 9602569 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D838C600CB for ; Fri, 3 Mar 2017 11:40:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C90CE28643 for ; Fri, 3 Mar 2017 11:40:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BDD0F28652; Fri, 3 Mar 2017 11:40:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 195C828649 for ; Fri, 3 Mar 2017 11:40:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FD066ECE3; Fri, 3 Mar 2017 11:40:09 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from metanate.com (dougal.metanate.com [90.155.101.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBDF96ECE3 for ; Fri, 3 Mar 2017 11:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=metanate.com; s=stronger; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=OXLUX+eYCYCOEtq/mGcSKqRM8tDm3yk/+pkOKgP4MQM=; b=VzfCPmYsoFAU4wZsYWToWf+LJDRwQg4kt8OhQcPK5mKXnwre/oFaN/WdtiRHFt86I9ZgxXOR3GR/WiT/R6iv3kkkCoB3By75uNe4TU1+rzLQigsVK4ygn1MmOLORoO3mEovEZzd7S1BxVxF+MRhvfBH30gwcAkX1F/HwP+Nj1lDJguTIGFpjDldROb8no/38FS6Q0VdYWnSLpt4c5w8u3PTlME3p5rVnYOjJag/tR1YCZWBCd0yxtbkntu560OqfVIUuUKp/vdRu/tb4NxSjGcce7He/0MTSbX4IMhaLREfICTZ/NmpKw/U94UTT6OGYpJKvLyKfMuNTW4//5pDudA==; Received: from johnkeeping.plus.com ([81.174.171.191] helo=localhost.localdomain) by shrek.metanate.com with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.83_RC2) (envelope-from ) id 1cjlYo-0004gn-Qe; Fri, 03 Mar 2017 11:39:46 +0000 Date: Fri, 3 Mar 2017 11:39:45 +0000 From: John Keeping To: Brian Norris Subject: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Message-ID: <20170303113945.3bd2cbd9.john@metanate.com> In-Reply-To: <20170302215643.GA49163@google.com> References: <20170224125506.21533-1-john@metanate.com> <20170224125506.21533-24-john@metanate.com> <20170302215643.GA49163@google.com> Organization: Metanate Ltd X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP This reset is required in order to fully reset the internal state of the MIPI controller. Signed-off-by: John Keeping Reviewed-by: Brian Norris Reviewed-by: Sean Paul Acked-by: Rob Herring --- On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote: > On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote: > > + /* > > + * Note that the reset was not defined in the initial device tree, so > > + * we have to be prepared for it not being found. > > + */ > > + apb_rst = devm_reset_control_get(dev, "apb"); > > Did this reset ever get documented in the device tree bindings? I > couldn't find it. Perhaps a follow-up patch is in order? Here's a patch to do that. .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt index 1753f0cc6fad..28d0b437d3cd 100644 --- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt +++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt @@ -13,8 +13,13 @@ Required properties: - ports: contain a port node with endpoint definitions as defined in [2]. For vopb,set the reg = <0> and set the reg = <1> for vopl. +Optional properties: +- resets: list of phandle + reset specifier pairs, as described in [3]. +- reset-names: string reset name, must be "apb". + [1] Documentation/devicetree/bindings/clock/clock-bindings.txt [2] Documentation/devicetree/bindings/media/video-interfaces.txt +[3] Documentation/devicetree/bindings/reset/reset.txt Example: mipi_dsi: mipi@ff960000 { @@ -25,6 +30,8 @@ Example: interrupts = ; clocks = <&cru SCLK_MIPI_24M>, <&cru PCLK_MIPI_DSI0>; clock-names = "ref", "pclk"; + resets = <&cru SRST_MIPIDSI0>; + reset-names = "apb"; rockchip,grf = <&grf>; status = "okay";