diff mbox

drm: qxl: add missing return check

Message ID 20170314075410.GB5984@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter March 14, 2017, 7:54 a.m. UTC 
My static checker complains that "release" is uninitialized if
qxl_alloc_release_reserved() fails, so let's add a check for that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Gerd Hoffmann March 14, 2017, 11:02 a.m. UTC | #1 
On Di, 2017-03-14 at 10:54 +0300, Dan Carpenter wrote:
> My static checker complains that "release" is uninitialized if
> qxl_alloc_release_reserved() fails, so let's add a check for that.

applied to drm-misc-next.

thanks,
  Gerd
diff mbox

Patch

diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 9548bb58d3bc..058340a002c2 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -572,6 +572,8 @@  static void qxl_cursor_atomic_update(struct drm_plane *plane,
 	ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd),
 					 QXL_RELEASE_CURSOR_CMD,
 					 &release, NULL);
+	if (ret)
+		return;
 
 	cmd = (struct qxl_cursor_cmd *) qxl_release_map(qdev, release);