From patchwork Thu Mar 16 00:08:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Engestrom X-Patchwork-Id: 9626861 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 17C3D60244 for ; Thu, 16 Mar 2017 00:17:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2F6F2808F for ; Thu, 16 Mar 2017 00:16:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D5DA5285E3; Thu, 16 Mar 2017 00:16:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E62A42808F for ; Thu, 16 Mar 2017 00:16:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 09AD86E985; Thu, 16 Mar 2017 00:16:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16BE96E985 for ; Thu, 16 Mar 2017 00:16:56 +0000 (UTC) Received: by mail-wr0-f194.google.com with SMTP id u48so3933089wrc.1 for ; Wed, 15 Mar 2017 17:16:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uM00LY6LUdD9H0Ra2/OROG9T9Uk/wO92gYmueJILbYc=; b=pzih0UOiC7lbgBvCRVWeOdazD7lwWx2CaeHdiyxyeQwXJdj7zHc7KYTCHZgSxydX+k EFH+YCxtfTDwbuaYgwehvRSQiyoEj3d9UehcCLH8/ssw4uXkqnUDRCC2BKKqt6Oe/nK/ Mj8NChoUzuX0Hyvvc4D6xSYsenHovS1ApcFUEZoYhMXGdkFW/yw4nOsur+/PRKwX2rna awc+36lNkmTtuHTT94QbRSPqSNfmirffEbX/WBKUT4Cbf8CZv0nCDLT7mKsJPiJ9dn4N 2Szz8U1mfTnKfGDZym2b6E8x90PscahlpcClYP3FaO24JxRWhz1gCbjkfCI9pMvmnrbb mPmQ== X-Gm-Message-State: AFeK/H3jxK9yhQC/IytdRVGkNV7tXiQz+Qlq+LZigh8qk3w/7uH7AXfzJcne/QnER0v7eQ== X-Received: by 10.223.142.141 with SMTP id q13mr5283701wrb.180.1489623414759; Wed, 15 Mar 2017 17:16:54 -0700 (PDT) Received: from localhost.localdomain (host109-147-98-210.range109-147.btcentralplus.com. [109.147.98.210]) by smtp.gmail.com with ESMTPSA id v186sm2247636wmv.2.2017.03.15.17.16.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Mar 2017 17:16:53 -0700 (PDT) From: Eric Engestrom To: dri-devel@lists.freedesktop.org Subject: [PATCH libdrm] atomic: fix atomic_add_unless() fallback's return value Date: Thu, 16 Mar 2017 00:08:59 +0000 Message-Id: <20170316000859.25038-1-eric@engestrom.ch> X-Mailer: git-send-email 2.12.0 In-Reply-To: References: Cc: David Shao , Eric Engestrom X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP According to the kernel documentation: Returns non-zero if @v was not @u, and zero otherwise. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100077 Fixes: 63fc571863aa64683400 ("atomic: add atomic_add_unless()") Signed-off-by: David Shao Reviewed-by: Eric Engestrom Signed-off-by: Eric Engestrom --- xf86atomic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xf86atomic.h b/xf86atomic.h index 922b37da..ecb1ba86 100644 --- a/xf86atomic.h +++ b/xf86atomic.h @@ -111,7 +111,7 @@ static inline int atomic_add_unless(atomic_t *v, int add, int unless) c = atomic_read(v); while (c != unless && (old = atomic_cmpxchg(v, c, c + add)) != c) c = old; - return c == unless; + return c != unless; } #endif