diff mbox

[09/15] drm/msm: Nerf zpos property

Message ID 20170403083304.9083-10-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter April 3, 2017, 8:32 a.m. UTC
It's not wired up, and if it is, it should be moved over to the new
fancy standardized zpos property exposed through
drm_plane_create_zpos_property().

Cc: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Daniel Vetter April 5, 2017, 1:24 p.m. UTC | #1
On Mon, Apr 03, 2017 at 10:32:58AM +0200, Daniel Vetter wrote:
> It's not wired up, and if it is, it should be moved over to the new
> fancy standardized zpos property exposed through
> drm_plane_create_zpos_property().
> 
> Cc: Rob Clark <robdclark@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Discussed this with Rob Clark on irc, I was wrong, this is all properly
wired up. No idea why I failed at parsing git grep output ... This should
be moved over to drm_plane_create_zpos_property(), but this patch here is
bogus. I'll drop it.
-Daniel

> ---
>  drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> index 60a5451ae0b9..9229c6e201a2 100644
> --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> @@ -108,8 +108,6 @@ static void mdp5_plane_install_properties(struct drm_plane *plane,
>  				create_enum, name##_prop_enum_list, \
>  				ARRAY_SIZE(name##_prop_enum_list))
>  
> -	INSTALL_RANGE_PROPERTY(zpos, ZPOS, 1, 255, 1);
> -
>  	mdp5_plane_install_rotation_property(dev, plane);
>  
>  #undef INSTALL_RANGE_PROPERTY
> -- 
> 2.11.0
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
index 60a5451ae0b9..9229c6e201a2 100644
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
@@ -108,8 +108,6 @@  static void mdp5_plane_install_properties(struct drm_plane *plane,
 				create_enum, name##_prop_enum_list, \
 				ARRAY_SIZE(name##_prop_enum_list))
 
-	INSTALL_RANGE_PROPERTY(zpos, ZPOS, 1, 255, 1);
-
 	mdp5_plane_install_rotation_property(dev, plane);
 
 #undef INSTALL_RANGE_PROPERTY