diff mbox

drm: bridge: dw-hdmi: Add a missing break statement

Message ID 20170406052132.GA26605@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter April 6, 2017, 5:21 a.m. UTC 
There was supposed to be a break before the next case statement.

Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Neil Armstrong April 6, 2017, 7:41 a.m. UTC | #1 
On 04/06/2017 07:21 AM, Dan Carpenter wrote:
> There was supposed to be a break before the next case statement.
> 
> Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 84cc949eae2b..8b605039c613 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
>  			frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
>  		frame.extended_colorimetry =
>  				HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
> +		break;
>  	case V4L2_YCBCR_ENC_709:
>  		if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV709)
>  			frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
> 

Thanks for the fix !

Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Neil Armstrong April 6, 2017, 8:58 a.m. UTC | #2 
On 04/06/2017 09:41 AM, Neil Armstrong wrote:
> On 04/06/2017 07:21 AM, Dan Carpenter wrote:
>> There was supposed to be a break before the next case statement.
>>
>> Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> index 84cc949eae2b..8b605039c613 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> @@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
>>  			frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
>>  		frame.extended_colorimetry =
>>  				HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
>> +		break;
>>  	case V4L2_YCBCR_ENC_709:
>>  		if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV709)
>>  			frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
>>
> 
> Thanks for the fix !
> 
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> 

Applied to drm-misc-next

Thanks,
Neil
diff mbox

Patch

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 84cc949eae2b..8b605039c613 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -1318,6 +1318,7 @@  static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
 			frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
 		frame.extended_colorimetry =
 				HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
+		break;
 	case V4L2_YCBCR_ENC_709:
 		if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV709)
 			frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;