| Message ID | 20170421003819.17685-1-krisman@collabora.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Apr 20, 2017 at 09:38:19PM -0300, Gabriel Krisman Bertazi wrote: > While reading drm_for_each_connector_iter, I noticed a mention to > drm_connector_begin which doesn't exist. It should be > drm_connector_get. > > Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> Fixes: b982dab1e66d ("drm: Rename connector list iterator API") Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > include/drm/drm_connector.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index 4eeda120e46d..ff428aa0953a 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -1031,7 +1031,7 @@ void drm_connector_list_iter_end(struct drm_connector_list_iter *iter); > * > * Note that @connector is only valid within the list body, if you want to use > * @connector after calling drm_connector_list_iter_end() then you need to grab > - * your own reference first using drm_connector_begin(). > + * your own reference first using drm_connector_get(). > */ > #define drm_for_each_connector_iter(connector, iter) \ > while ((connector = drm_connector_list_iter_next(iter))) > -- > 2.11.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Daniel Vetter <daniel@ffwll.ch> writes: > On Thu, Apr 20, 2017 at 09:38:19PM -0300, Gabriel Krisman Bertazi wrote: >> While reading drm_for_each_connector_iter, I noticed a mention to >> drm_connector_begin which doesn't exist. It should be >> drm_connector_get. >> >> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> > > Fixes: b982dab1e66d ("drm: Rename connector list iterator API") > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Hi Daniel, Can you apply this one? I couldn't find it in drm-misc yet.
On Wed, May 17, 2017 at 03:43:18PM -0300, Gabriel Krisman Bertazi wrote: > Daniel Vetter <daniel@ffwll.ch> writes: > > > On Thu, Apr 20, 2017 at 09:38:19PM -0300, Gabriel Krisman Bertazi wrote: > >> While reading drm_for_each_connector_iter, I noticed a mention to > >> drm_connector_begin which doesn't exist. It should be > >> drm_connector_get. > >> > >> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> > > > > Fixes: b982dab1e66d ("drm: Rename connector list iterator API") > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > Hi Daniel, > > Can you apply this one? I couldn't find it in drm-misc yet. Oh I thought you have commit rights, otherwise I'd have pushed it. -Daniel
Daniel Vetter <daniel@ffwll.ch> writes: > On Wed, May 17, 2017 at 03:43:18PM -0300, Gabriel Krisman Bertazi wrote: >> Daniel Vetter <daniel@ffwll.ch> writes: >> >> > On Thu, Apr 20, 2017 at 09:38:19PM -0300, Gabriel Krisman Bertazi wrote: >> >> While reading drm_for_each_connector_iter, I noticed a mention to >> >> drm_connector_begin which doesn't exist. It should be >> >> drm_connector_get. >> >> >> >> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> >> > >> > Fixes: b982dab1e66d ("drm: Rename connector list iterator API") >> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> >> >> Hi Daniel, >> >> Can you apply this one? I couldn't find it in drm-misc yet. > > Oh I thought you have commit rights, otherwise I'd have pushed it. Yep, I don't have commit rights yet. Thanks for pushing, Daniel.
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 4eeda120e46d..ff428aa0953a 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -1031,7 +1031,7 @@ void drm_connector_list_iter_end(struct drm_connector_list_iter *iter); * * Note that @connector is only valid within the list body, if you want to use * @connector after calling drm_connector_list_iter_end() then you need to grab - * your own reference first using drm_connector_begin(). + * your own reference first using drm_connector_get(). */ #define drm_for_each_connector_iter(connector, iter) \ while ((connector = drm_connector_list_iter_next(iter)))
While reading drm_for_each_connector_iter, I noticed a mention to drm_connector_begin which doesn't exist. It should be drm_connector_get. Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> --- include/drm/drm_connector.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)