| Message ID | 20170509181539.30278-1-eric@anholt.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Looks good for Cygnus. On 17-05-09 11:15 AM, Eric Anholt wrote: > With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" > to let the module get built on a cygnus-only kernel. However, I > anticipate having a port for Kona soon, so just present the module on > all of BCM. > > v2: Keep allowing selection with ARCH_BCM2835, since ARCH_BCM doesn't > exist on arm64. > > Signed-off-by: Eric Anholt <eric@anholt.net> > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> (v1) Acked-by: Scott Branden <scott.branden@broadcom.com> > --- > drivers/gpu/drm/vc4/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig > index 973b4203c0b2..b16aefe4a8d3 100644 > --- a/drivers/gpu/drm/vc4/Kconfig > +++ b/drivers/gpu/drm/vc4/Kconfig > @@ -1,6 +1,6 @@ > config DRM_VC4 > tristate "Broadcom VC4 Graphics" > - depends on ARCH_BCM2835 || COMPILE_TEST > + depends on ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST > depends on DRM > depends on SND && SND_SOC > depends on COMMON_CLK >
On 05/09/2017 11:15 AM, Eric Anholt wrote: > With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" > to let the module get built on a cygnus-only kernel. However, I > anticipate having a port for Kona soon, so just present the module on > all of BCM. > > v2: Keep allowing selection with ARCH_BCM2835, since ARCH_BCM doesn't > exist on arm64. Nit: the patch changelog usually goes after the "---" line so it gets stripped with git am. Not necessary to resubmit just because of that. > > Signed-off-by: Eric Anholt <eric@anholt.net> > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> (v1) Acked-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/gpu/drm/vc4/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig > index 973b4203c0b2..b16aefe4a8d3 100644 > --- a/drivers/gpu/drm/vc4/Kconfig > +++ b/drivers/gpu/drm/vc4/Kconfig > @@ -1,6 +1,6 @@ > config DRM_VC4 > tristate "Broadcom VC4 Graphics" > - depends on ARCH_BCM2835 || COMPILE_TEST > + depends on ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST > depends on DRM > depends on SND && SND_SOC > depends on COMMON_CLK >
Florian Fainelli <f.fainelli@gmail.com> writes: > On 05/09/2017 11:15 AM, Eric Anholt wrote: >> With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" >> to let the module get built on a cygnus-only kernel. However, I >> anticipate having a port for Kona soon, so just present the module on >> all of BCM. >> >> v2: Keep allowing selection with ARCH_BCM2835, since ARCH_BCM doesn't >> exist on arm64. > > Nit: the patch changelog usually goes after the "---" line so it gets > stripped with git am. Not necessary to resubmit just because of that. Behavior on that front differs between subsystems. DRM is one where the changelog is generally retained.
On 05/09/2017 04:16 PM, Eric Anholt wrote: > Florian Fainelli <f.fainelli@gmail.com> writes: > >> On 05/09/2017 11:15 AM, Eric Anholt wrote: >>> With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" >>> to let the module get built on a cygnus-only kernel. However, I >>> anticipate having a port for Kona soon, so just present the module on >>> all of BCM. >>> >>> v2: Keep allowing selection with ARCH_BCM2835, since ARCH_BCM doesn't >>> exist on arm64. >> >> Nit: the patch changelog usually goes after the "---" line so it gets >> stripped with git am. Not necessary to resubmit just because of that. > > Behavior on that front differs between subsystems. DRM is one where the > changelog is generally retained. Once the patch lands in git, it's sort of interesting to know its history and the context surrounding this acceptance, but there is already so much context being lost already (like where are all other patches from the same patch series for instance?) that I wonder if we should not add more to it (like links to past iterations and so on). Thanks for explaining how DRM works in that regard, though.
diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig index 973b4203c0b2..b16aefe4a8d3 100644 --- a/drivers/gpu/drm/vc4/Kconfig +++ b/drivers/gpu/drm/vc4/Kconfig @@ -1,6 +1,6 @@ config DRM_VC4 tristate "Broadcom VC4 Graphics" - depends on ARCH_BCM2835 || COMPILE_TEST + depends on ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST depends on DRM depends on SND && SND_SOC depends on COMMON_CLK
With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" to let the module get built on a cygnus-only kernel. However, I anticipate having a port for Kona soon, so just present the module on all of BCM. v2: Keep allowing selection with ARCH_BCM2835, since ARCH_BCM doesn't exist on arm64. Signed-off-by: Eric Anholt <eric@anholt.net> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> (v1) --- drivers/gpu/drm/vc4/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)